From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6A06C4743C for ; Mon, 14 Jun 2021 10:03:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C8E061241 for ; Mon, 14 Jun 2021 10:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C8E061241 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C40F26B006C; Mon, 14 Jun 2021 06:03:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF0A26B006E; Mon, 14 Jun 2021 06:03:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB8076B0070; Mon, 14 Jun 2021 06:03:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 7C8E66B006C for ; Mon, 14 Jun 2021 06:03:38 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 0424D181AEF10 for ; Mon, 14 Jun 2021 10:03:38 +0000 (UTC) X-FDA: 78251892516.34.6D2EFB5 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id 0941237E for ; Mon, 14 Jun 2021 10:03:25 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id C9C1368AFE; Mon, 14 Jun 2021 12:03:34 +0200 (CEST) Date: Mon, 14 Jun 2021 12:03:34 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Andrew Morton , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Message-ID: <20210614100334.GA10629@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-4-hch@lst.de> <20210614095107.GD26615@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614095107.GD26615@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf12.hostedemail.com; dkim=none; spf=none (imf12.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 0941237E X-Stat-Signature: k4tj4itzaiqmxzsa9gxefm7i9kqpxkgp X-HE-Tag: 1623665005-920362 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000250, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 11:51:07AM +0200, Jan Kara wrote: > On Mon 14-06-21 08:15:12, Christoph Hellwig wrote: > > Remove the CONFIG_BLOCK default to __set_page_dirty_buffers and just > > wire that method up for the missing instances. > > > > Signed-off-by: Christoph Hellwig > > Make sense. Did you somehow autogenerate this? If this patch would race > with addition of new aops struct, we'd get null-ptr-defer out of that so > maybe providing the script would be better. But other than that the changes > look good to me. You can add: No, this was done manually as I audited all instances for actually being able to dirty pages.