linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Yu Zhao <yuzhao@google.com>
Cc: Minchan Kim <minchan@kernel.org>, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmscan.c: fix potential deadlock in reclaim_pages()
Date: Mon, 14 Jun 2021 15:10:30 -0700	[thread overview]
Message-ID: <20210614151030.35fd6ecfecc2e3df2d7c5dc0@linux-foundation.org> (raw)
In-Reply-To: <20210614194727.2684053-1-yuzhao@google.com>

On Mon, 14 Jun 2021 13:47:27 -0600 Yu Zhao <yuzhao@google.com> wrote:

> Use memalloc_noreclaim_save()/memalloc_noreclaim_restore() in
> reclaim_pages() to prevent the page reclaim from going into the block
> I/O layer recursively and deadlock.

Well.  Deadlocking the kernel is considered a bad thing ;)

From the lack of a cc:stable I'm assuming that this is a theoretical
from-code-inspection thing and that such a deadlock has not been
observed?

If not, why do we think that is the case?  What is saving us?

(In other words, more detailed changelogging, please!)


  reply	other threads:[~2021-06-14 22:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 19:47 [PATCH] mm/vmscan.c: fix potential deadlock in reclaim_pages() Yu Zhao
2021-06-14 22:10 ` Andrew Morton [this message]
2021-06-22  7:46   ` [PATCH v2] " Yu Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210614151030.35fd6ecfecc2e3df2d7c5dc0@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).