From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Dong Aisheng <dongas86@gmail.com>, Will Deacon <will@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
iommu@lists.linux-foundation.org,
open list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/1] dma: coherent: check no-map property for arm64
Date: Mon, 14 Jun 2021 17:36:03 +0200 [thread overview]
Message-ID: <20210614153603.GA1998@lst.de> (raw)
In-Reply-To: <6f897830-301f-3eb4-785f-de446476e676@arm.com>
On Mon, Jun 14, 2021 at 04:34:05PM +0100, Robin Murphy wrote:
>> Looking at the rmem_dma_device_init() -> dma_init_coherent_memory(), it
>> ends up calling memremap(MEMREMAP_WC) which would warn if it intersects
>> with system RAM regardless of the architecture. If the memory region is
>> nomap, it doesn't end up as IORESOURCE_SYSTEM_RAM, so memremap() won't
>> warn. But why is this specific only to arm (or arm64)?
>
> Didn't some ARMv7 implementations permit unexpected cache hits for the
> non-cacheable address if the same PA has been speculatively fetched via the
> cacheable alias?
If we care about that we need to change these platforms to change the
cache attributes of the kernel direct mapping instead of using vmap.
We already have code to do that for openrisc, someone just needs to
write the glue code for other platforms.
next prev parent reply other threads:[~2021-06-14 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210611131056.3731084-1-aisheng.dong@nxp.com>
2021-06-14 8:36 ` [PATCH 1/1] dma: coherent: check no-map property for arm64 Will Deacon
2021-06-14 10:07 ` Dong Aisheng
2021-06-14 14:51 ` Catalin Marinas
2021-06-14 15:34 ` Robin Murphy
2021-06-14 15:36 ` Christoph Hellwig [this message]
2021-06-15 7:19 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614153603.GA1998@lst.de \
--to=hch@lst.de \
--cc=aisheng.dong@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=dongas86@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=m.szyprowski@samsung.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).