From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5AF1C2B9F4 for ; Mon, 14 Jun 2021 15:55:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 393CF60FEE for ; Mon, 14 Jun 2021 15:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 393CF60FEE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9681E6B006C; Mon, 14 Jun 2021 11:55:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92B876B006E; Mon, 14 Jun 2021 11:55:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81AA96B0070; Mon, 14 Jun 2021 11:55:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 529476B006C for ; Mon, 14 Jun 2021 11:55:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E4BE9180AD806 for ; Mon, 14 Jun 2021 15:55:32 +0000 (UTC) X-FDA: 78252779304.05.1D8FE08 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf08.hostedemail.com (Postfix) with ESMTP id 2DCB0801936E for ; Mon, 14 Jun 2021 15:55:24 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 330D768AFE; Mon, 14 Jun 2021 17:55:30 +0200 (CEST) Date: Mon, 14 Jun 2021 17:55:30 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: remove the implicit .set_page_dirty default Message-ID: <20210614155530.GA2563@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614155333.GB2413@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614155333.GB2413@lst.de> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=none (imf08.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 2DCB0801936E X-Stat-Signature: thb8jdcr6mm4ygcagkcp5xpxx6daf8mq X-HE-Tag: 1623686124-766311 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 14, 2021 at 05:53:33PM +0200, Christoph Hellwig wrote: > On Mon, Jun 14, 2021 at 01:23:22PM +0100, Matthew Wilcox wrote: > > i have a somewhat similar series in the works ... > > > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/1e7e8c2d82666b55690705d5bbe908e31d437edb > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/bf767a4969c0bc6735275ff7457a8082eef4c3fd > > > > ... the other patches rather depend on the folio work. > > Yes, these looks useful to me as well. And in fact I suspect the code in __set_page_dirty_no_writeback should really be the default if no ->set_page_dirty is set up. It is the same code as the no-mapping case and really makes sense as the default case..