From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA82AC48BE8 for ; Tue, 15 Jun 2021 16:38:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D5FB617C9 for ; Tue, 15 Jun 2021 16:38:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D5FB617C9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 42EF46B0072; Tue, 15 Jun 2021 12:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F27C6B0073; Tue, 15 Jun 2021 12:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CE756B0074; Tue, 15 Jun 2021 12:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0131.hostedemail.com [216.40.44.131]) by kanga.kvack.org (Postfix) with ESMTP id F1BA96B0072 for ; Tue, 15 Jun 2021 12:38:44 -0400 (EDT) Received: from smtpin32.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 93272181AC9BF for ; Tue, 15 Jun 2021 16:38:44 +0000 (UTC) X-FDA: 78256516968.32.6E6BF64 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf03.hostedemail.com (Postfix) with ESMTP id 53A40C00CBC0 for ; Tue, 15 Jun 2021 16:38:34 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 6F0FC68AFE; Tue, 15 Jun 2021 18:38:42 +0200 (CEST) Date: Tue, 15 Jun 2021 18:38:42 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/6] fs: Remove noop_set_page_dirty() Message-ID: <20210615163842.GE1600@lst.de> References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-6-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615162342.1669332-6-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=none; spf=none (imf03.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam02 X-Stat-Signature: rjrb5akbjz5kryar1mheo3mqnhpqcxgw X-Rspamd-Queue-Id: 53A40C00CBC0 X-HE-Tag: 1623775114-531936 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 15, 2021 at 05:23:41PM +0100, Matthew Wilcox (Oracle) wrote: > Use __set_page_dirty_no_writeback() instead. This will set the dirty > bit on the page, which will be used to avoid calling set_page_dirty() > in the future. It will have no effect on actually writing the page > back, as the pages are not on any LRU lists. Looks sane to me, but I'd really like to have Dan to look over this..