From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48F2CC48BE5 for ; Tue, 15 Jun 2021 16:39:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0EC9F61625 for ; Tue, 15 Jun 2021 16:39:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0EC9F61625 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A499C6B0070; Tue, 15 Jun 2021 12:39:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A204B6B0071; Tue, 15 Jun 2021 12:39:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 922156B0073; Tue, 15 Jun 2021 12:39:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 5DD846B0070 for ; Tue, 15 Jun 2021 12:39:06 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 03CB78249980 for ; Tue, 15 Jun 2021 16:39:06 +0000 (UTC) X-FDA: 78256517892.07.7B6E89C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id D750AE00023F for ; Tue, 15 Jun 2021 16:38:52 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9785B68AFE; Tue, 15 Jun 2021 18:39:03 +0200 (CEST) Date: Tue, 15 Jun 2021 18:39:03 +0200 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] mm: Move page dirtying prototypes from mm.h Message-ID: <20210615163903.GF1600@lst.de> References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-7-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615162342.1669332-7-willy@infradead.org> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: orxk7h1b3zzaaupbwbnbt1h4hwij8n5f X-Rspamd-Queue-Id: D750AE00023F X-Rspamd-Server: rspam06 X-HE-Tag: 1623775132-286055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 15, 2021 at 05:23:42PM +0100, Matthew Wilcox (Oracle) wrote: > These functions implement the address_space ->set_page_dirty operation > and should live in pagemap.h, not mm.h so that the rest of the kernel > doesn't get funny ideas about calling them directly. > > Signed-off-by: Matthew Wilcox (Oracle) Looks good: Reviewed-by: Christoph Hellwig