From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C9E0C48BE5 for ; Tue, 15 Jun 2021 17:35:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B7A6613FA for ; Tue, 15 Jun 2021 17:35:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B7A6613FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B910A6B006E; Tue, 15 Jun 2021 13:34:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B683C6B0071; Tue, 15 Jun 2021 13:34:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A57B26B0072; Tue, 15 Jun 2021 13:34:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0250.hostedemail.com [216.40.44.250]) by kanga.kvack.org (Postfix) with ESMTP id 743106B006E for ; Tue, 15 Jun 2021 13:34:59 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 1645C824999B for ; Tue, 15 Jun 2021 17:34:59 +0000 (UTC) X-FDA: 78256658718.37.F006E12 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf18.hostedemail.com (Postfix) with ESMTP id C0EF420010B7 for ; Tue, 15 Jun 2021 17:34:49 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 9D04C68C7B; Tue, 15 Jun 2021 19:34:54 +0200 (CEST) Date: Tue, 15 Jun 2021 19:34:53 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Greg Kroah-Hartman , Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers Message-ID: <20210615173453.GA2849@lst.de> References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: C0EF420010B7 X-Stat-Signature: cqpcaq1r6xgyqi43kfm3jm5rwikjwhre Authentication-Results: imf18.hostedemail.com; dkim=none; spf=none (imf18.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-HE-Tag: 1623778489-149342 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 15, 2021 at 06:32:37PM +0100, Matthew Wilcox wrote: > On Tue, Jun 15, 2021 at 07:19:59PM +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 15, 2021 at 05:23:39PM +0100, Matthew Wilcox (Oracle) wrote: > > Using __ functions in structures in different modules feels odd to me. > > Why not just have iomap_set_page_dirty be a #define to this function now > > if you want to do this? > > > > Or take the __ off of the function name? > > > > Anyway, logic here is fine, but feels odd. > > heh, that was how I did it the first time. Then I thought that it was > better to follow Christoph's patch: > > static const struct address_space_operations adfs_aops = { > + .set_page_dirty = __set_page_dirty_buffers, > (etc) Eventually everything around set_page_dirty should be changed to operate on folios, and that will be a good time to come up with a sane naming scheme without introducing extra churn.