From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40380C48BDF for ; Fri, 18 Jun 2021 07:53:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE1386120A for ; Fri, 18 Jun 2021 07:53:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE1386120A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 66D266B0070; Fri, 18 Jun 2021 03:53:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7556B0071; Fri, 18 Jun 2021 03:53:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 435666B0072; Fri, 18 Jun 2021 03:53:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0111.hostedemail.com [216.40.44.111]) by kanga.kvack.org (Postfix) with ESMTP id 104886B0070 for ; Fri, 18 Jun 2021 03:53:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A16EF180AD817 for ; Fri, 18 Jun 2021 07:53:37 +0000 (UTC) X-FDA: 78266080074.07.A78FC95 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id 256DAC00F799 for ; Fri, 18 Jun 2021 07:53:37 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CDDED21AF1; Fri, 18 Jun 2021 07:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624002815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nvivQRnbw0lq6DwS0bzrS7/TCENjmTPFP8+H7Q1VDjM=; b=RylMVhSJDCZ4vYAKct7MP45fy/0v8eXlt6fJ9GyAOWM8TtTkVm9ikFHwe8B7TZOPAu4jhr bEiZE2C0eHuh5zIYsfzy+Bl9CQYH2qWLWGLaVnLQFtI1mF/DpX2dS/8yeYLCx31RDjf+Mv J0R2uux6U559FszYSQSUsuVQ1hlF2AY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624002815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nvivQRnbw0lq6DwS0bzrS7/TCENjmTPFP8+H7Q1VDjM=; b=gNbjBM021OmwoYdiVo8jhqJECQU7QIsvLkKaS1cS7dmi9EqM2DaD8d2OkKMPEhDUNap8bo EcNSVqbUct3OYaBA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 20034118DD; Fri, 18 Jun 2021 07:53:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624002815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nvivQRnbw0lq6DwS0bzrS7/TCENjmTPFP8+H7Q1VDjM=; b=RylMVhSJDCZ4vYAKct7MP45fy/0v8eXlt6fJ9GyAOWM8TtTkVm9ikFHwe8B7TZOPAu4jhr bEiZE2C0eHuh5zIYsfzy+Bl9CQYH2qWLWGLaVnLQFtI1mF/DpX2dS/8yeYLCx31RDjf+Mv J0R2uux6U559FszYSQSUsuVQ1hlF2AY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624002815; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nvivQRnbw0lq6DwS0bzrS7/TCENjmTPFP8+H7Q1VDjM=; b=gNbjBM021OmwoYdiVo8jhqJECQU7QIsvLkKaS1cS7dmi9EqM2DaD8d2OkKMPEhDUNap8bo EcNSVqbUct3OYaBA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id xR5rBP9QzGD2TgAALh3uQQ (envelope-from ); Fri, 18 Jun 2021 07:53:35 +0000 Date: Fri, 18 Jun 2021 09:53:33 +0200 From: Oscar Salvador To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yang Shi , Dave Hansen , Yang Shi , Michal Hocko , Wei Xu , Dan Williams , David Hildenbrand Subject: Re: [PATCH -V8 04/10] mm/migrate: make migrate_pages() return nr_succeeded Message-ID: <20210618075328.GA23470@linux> References: <20210618061537.434999-1-ying.huang@intel.com> <20210618061537.434999-5-ying.huang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618061537.434999-5-ying.huang@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RylMVhSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gNbjBM02; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=RylMVhSJ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=gNbjBM02; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=none X-Stat-Signature: dhn48cqmakf33s4jjzf5c85egqrn5oix X-Rspamd-Queue-Id: 256DAC00F799 X-Rspamd-Server: rspam06 X-HE-Tag: 1624002817-39637 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 18, 2021 at 02:15:31PM +0800, Huang Ying wrote: > From: Yang Shi > > The migrate_pages() returns the number of pages that were not migrated, > or an error code. When returning an error code, there is no way to know > how many pages were migrated or not migrated. > > In the following patch, migrate_pages() is used to demote pages to PMEM > node, we need account how many pages are reclaimed (demoted) since page > reclaim behavior depends on this. Add *nr_succeeded parameter to make > migrate_pages() return how many pages are demoted successfully for all > cases. > > Signed-off-by: Yang Shi > Signed-off-by: Dave Hansen > Signed-off-by: "Huang, Ying" > Reviewed-by: Yang Shi > Cc: Michal Hocko > Cc: Wei Xu > Cc: Dan Williams > Cc: David Hildenbrand > Cc: osalvador I thought we all agreed on making nr_succeed an optional argument [1]. It reduced the churn quite a lot. [1] https://patchwork.kernel.org/comment/24104453/ -- Oscar Salvador SUSE L3