From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29165C48BDF for ; Fri, 18 Jun 2021 11:59:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 939DE613E9 for ; Fri, 18 Jun 2021 11:59:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 939DE613E9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AD6DD6B0070; Fri, 18 Jun 2021 07:59:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A87596B0071; Fri, 18 Jun 2021 07:59:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9270C6B0072; Fri, 18 Jun 2021 07:59:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 614306B0070 for ; Fri, 18 Jun 2021 07:59:56 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EE07E8249980 for ; Fri, 18 Jun 2021 11:59:55 +0000 (UTC) X-FDA: 78266700750.11.7F41D45 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf07.hostedemail.com (Postfix) with ESMTP id 74DD2A0009C5 for ; Fri, 18 Jun 2021 11:59:55 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 15IBtiB0027264; Fri, 18 Jun 2021 11:59:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=I2WMfVGP9eOEFw5CfS9wOgqp0AByjV95xnifyy5/Rnw=; b=a1htEw6hgtdATijme0O5sUHHc1f4Bxg8pJdVvwYNe559m1kFRC4j5isqzOx29cIfYM4D N7U/q+FtwcJ7oiJqfHhChhDEsawlRUbB6xBIT2eoBdi7GkeneIFSB+8+ahss13fdSdhO co0TUjfQ/9LDWOgdFKo88DJe1tvsvN9t+fbIqXuHBvZue3yk74btnOs6vtHDDrg2Uz3B su/qNvzs4P7cCbCCVY5yWOsKdQBGNYtBKpB8yT9Mw1CQAHmLjCPNCZrHOwumC9ooddIb 8NXeUePsL9JrgkgBl0y6O3AFeW71MXesD9tcRQu0DnNhw7KtzdaiDfbtS3MrBTH9taug UQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 39893qsr2f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Jun 2021 11:59:54 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 15IBtcoJ132795; Fri, 18 Jun 2021 11:59:53 GMT Received: from pps.reinject (localhost [127.0.0.1]) by userp3020.oracle.com with ESMTP id 396waysk08-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Jun 2021 11:59:53 +0000 Received: from userp3020.oracle.com (userp3020.oracle.com [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 15IBxqcw144111; Fri, 18 Jun 2021 11:59:52 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3020.oracle.com with ESMTP id 396waysk02-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 18 Jun 2021 11:59:52 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 15IBxoDJ012075; Fri, 18 Jun 2021 11:59:50 GMT Received: from kadam (/102.222.70.252) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 18 Jun 2021 04:59:49 -0700 Date: Fri, 18 Jun 2021 14:59:43 +0300 From: Dan Carpenter To: Mel Gorman Cc: linux-mm@kvack.org Subject: Re: [bug report] mm/page_alloc: add an array-based interface to the bulk page allocator Message-ID: <20210618115943.GY1901@kadam> References: <20210618101441.GS30378@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618101441.GS30378@techsingularity.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-ORIG-GUID: m0tro7x4Pffz2G47bfa8ASK99QQWoteS X-Proofpoint-GUID: m0tro7x4Pffz2G47bfa8ASK99QQWoteS Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2020-01-29 header.b=a1htEw6h; spf=none (imf07.hostedemail.com: domain of dan.carpenter@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=dan.carpenter@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Stat-Signature: xiem856ukgh3pyezar4kdbq6zeofaas5 X-Rspamd-Queue-Id: 74DD2A0009C5 X-Rspamd-Server: rspam06 X-HE-Tag: 1624017595-918008 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000237, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 18, 2021 at 11:14:41AM +0100, Mel Gorman wrote: > On Fri, Jun 18, 2021 at 12:03:45PM +0300, Dan Carpenter wrote: > > Hello Mel Gorman, > > > > The patch 0f87d9d30f21: "mm/page_alloc: add an array-based interface > > to the bulk page allocator" from Apr 29, 2021, leads to the following > > static checker warning: > > > > mm/page_alloc.c:5338 __alloc_pages_bulk() > > warn: potentially one past the end of array 'page_array[nr_populated]' > > > > Thanks Dan. > > Does this work for you? > It works for me. It doesn't silence the Smatch warning because Smatch thinks that all the callers pass a non-NULL "page_array" and gets confused by the "if (page_array)" checks. :/ regards, dan carpenter