From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08BA3C48BE5 for ; Mon, 21 Jun 2021 05:26:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41D486108E for ; Mon, 21 Jun 2021 05:26:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41D486108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8B0756B006E; Mon, 21 Jun 2021 01:26:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8604C6B0075; Mon, 21 Jun 2021 01:26:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7011C6B0078; Mon, 21 Jun 2021 01:26:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 3C7856B006E for ; Mon, 21 Jun 2021 01:26:17 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id A7D74180AD817 for ; Mon, 21 Jun 2021 05:26:16 +0000 (UTC) X-FDA: 78276595152.23.553B026 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf11.hostedemail.com (Postfix) with ESMTP id 1D49920015C4 for ; Mon, 21 Jun 2021 05:26:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 1E33B68BEB; Mon, 21 Jun 2021 07:26:13 +0200 (CEST) Date: Mon, 21 Jun 2021 07:26:12 +0200 From: Christoph Hellwig To: Dmitry Osipenko , Tyler Hicks Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ecryptfs@vger.kernel.org Subject: Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Message-ID: <20210621052612.GA4064@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=none (imf11.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Stat-Signature: xs6qgdzgxjg81mus8afo3suu581har98 X-Rspamd-Queue-Id: 1D49920015C4 X-Rspamd-Server: rspam06 X-HE-Tag: 1624253175-328192 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 18, 2021 at 10:23:55PM +0300, Dmitry Osipenko wrote: > > 21 files changed, 29 insertions(+), 14 deletions(-) > > The ecryptfs is now crashing with NULL deference, please fix. Which means it crashed the same before on configs without CONFIG_BLOCK. Tyler, can you look at what ecryptfs should do for ->set_page_dirty? Currently it implicitly gets __set_page_dirty_buffers for kernels with COFIG_BLOCK set, but given that this function looks at buffer_heads that ecryptfs doesn't use it can't really be the right choice. __set_page_dirty_nobuffers will probably work, but I'd love to see an audit of the page dirtying and writeback for ecryptfs while we're at it.