From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C57DC11F66 for ; Tue, 29 Jun 2021 13:52:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9C2E761DC4 for ; Tue, 29 Jun 2021 13:52:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C2E761DC4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EFC156B00AD; Tue, 29 Jun 2021 09:52:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EACF48D00F0; Tue, 29 Jun 2021 09:52:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D74396B00AF; Tue, 29 Jun 2021 09:52:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id B4B9E6B00AD for ; Tue, 29 Jun 2021 09:52:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 91F80181E4363 for ; Tue, 29 Jun 2021 13:52:07 +0000 (UTC) X-FDA: 78306900294.29.22B2196 Received: from outbound-smtp53.blacknight.com (outbound-smtp53.blacknight.com [46.22.136.237]) by imf04.hostedemail.com (Postfix) with ESMTP id E3E225000084 for ; Tue, 29 Jun 2021 13:52:06 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp53.blacknight.com (Postfix) with ESMTPS id 4A371FADF4 for ; Tue, 29 Jun 2021 14:52:05 +0100 (IST) Received: (qmail 23195 invoked from network); 29 Jun 2021 13:52:05 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Jun 2021 13:52:05 -0000 Date: Tue, 29 Jun 2021 14:52:03 +0100 From: Mel Gorman To: Wonhyuk Yang Cc: linux-mm@kvack.org, Andrew Morton , Vlastimil Babka Subject: Re: [PATCH v2] mm/compaction: fix 'limit' in fast_isolate_freepages Message-ID: <20210629135203.GF3840@techsingularity.net> References: <20210626082443.22547-1-vvghjk1234@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210626082443.22547-1-vvghjk1234@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E3E225000084 X-Stat-Signature: 73jx7e3su7ot73pbpzagsxtpj5shuxi4 Authentication-Results: imf04.hostedemail.com; dkim=none; spf=pass (imf04.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.237 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none X-HE-Tag: 1624974726-532293 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000026, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jun 26, 2021 at 05:24:43PM +0900, Wonhyuk Yang wrote: > Because of 'min(1, ...)', fast_isolate_freepages set 'limit' > to 0 or 1. This takes away the opportunities of find candinate > pages. So, by making enough scans available, increases the > probability of finding the appropriate freepage. > > Tested it on the thpscale and the results are as follows. > > 5.12.0 5.12.0 > valnilla patched > Amean fault-both-1 598.15 ( 0.00%) 592.56 ( 0.93%) > Amean fault-both-3 1494.47 ( 0.00%) 1514.35 ( -1.33%) > Amean fault-both-5 2519.48 ( 0.00%) 2471.76 ( 1.89%) > Amean fault-both-7 3173.85 ( 0.00%) 3079.19 ( 2.98%) > Amean fault-both-12 8063.83 ( 0.00%) 7858.29 ( 2.55%) > Amean fault-both-18 8781.20 ( 0.00%) 7827.70 * 10.86%* > Amean fault-both-24 12576.44 ( 0.00%) 12250.20 ( 2.59%) > Amean fault-both-30 18503.27 ( 0.00%) 17528.11 * 5.27%* > Amean fault-both-32 16133.69 ( 0.00%) 13874.24 * 14.00%* > > 5.12.0 5.12.0 > vanilla patched > Ops Compaction migrate scanned 6547133.00 5963901.00 > Ops Compaction free scanned 32452453.00 26609101.00 > > 5.12 5.12 > vanilla patched > Duration User 27.99 28.84 > Duration System 244.08 236.76 > Duration Elapsed 78.27 78.38 > > Fixes: 5a811889de10f ("mm, compaction: use free lists to quickly locate a migration target") > Signed-off-by: Wonhyuk Yang Acked-by: Mel Gorman -- Mel Gorman SUSE Labs