From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBE36C07E9B for ; Tue, 6 Jul 2021 17:51:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 70B6561C67 for ; Tue, 6 Jul 2021 17:51:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 70B6561C67 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 14ECB6B0011; Tue, 6 Jul 2021 13:51:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FF7E6B0070; Tue, 6 Jul 2021 13:51:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE1876B0071; Tue, 6 Jul 2021 13:50:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0045.hostedemail.com [216.40.44.45]) by kanga.kvack.org (Postfix) with ESMTP id C59206B0011 for ; Tue, 6 Jul 2021 13:50:59 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3FFD0181D553B for ; Tue, 6 Jul 2021 17:50:59 +0000 (UTC) X-FDA: 78332903838.34.51FFEFF Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf20.hostedemail.com (Postfix) with ESMTP id CC0A7D000099 for ; Tue, 6 Jul 2021 17:50:58 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id CFD2461C63; Tue, 6 Jul 2021 17:50:55 +0000 (UTC) Date: Tue, 6 Jul 2021 18:50:52 +0100 From: Catalin Marinas To: Robin Murphy Cc: Chen Huang , Al Viro , Matthew Wilcox , Christoph Hellwig , Mark Rutland , Andrew Morton , Stephen Rothwell , Randy Dunlap , Will Deacon , Linux ARM , linux-mm , open list Subject: Re: [BUG] arm64: an infinite loop in generic_perform_write() Message-ID: <20210706175052.GD15218@arm.com> References: <1c635945-fb25-8871-7b34-f475f75b2caf@huawei.com> <27fbb8c1-2a65-738f-6bec-13f450395ab7@arm.com> <20210624185554.GC25097@arm.com> <20210625103905.GA20835@arm.com> <7f14271a-9b2f-1afc-3caf-c4e5b36efa73@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7f14271a-9b2f-1afc-3caf-c4e5b36efa73@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CC0A7D000099 Authentication-Results: imf20.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf20.hostedemail.com: domain of cmarinas@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=cmarinas@kernel.org X-Stat-Signature: zjg74yk4f9jjygdafhejr4wy1eu4gjki X-HE-Tag: 1625593858-348847 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 28, 2021 at 05:22:30PM +0100, Robin Murphy wrote: > diff --git a/arch/arm64/lib/copy_to_user.S b/arch/arm64/lib/copy_to_user.S > index 043da90f5dd7..cfb598ae4812 100644 > --- a/arch/arm64/lib/copy_to_user.S > +++ b/arch/arm64/lib/copy_to_user.S > @@ -32,7 +32,7 @@ > .endm > .macro strh1 reg, ptr, val > - user_ldst 9998f, sttrh, \reg, \ptr, \val > + user_ldst 9997f, sttrh, \reg, \ptr, \val > .endm > .macro ldr1 reg, ptr, val > @@ -40,7 +40,7 @@ > .endm > .macro str1 reg, ptr, val > - user_ldst 9998f, sttr, \reg, \ptr, \val > + user_ldst 9997f, sttr, \reg, \ptr, \val > .endm > .macro ldp1 reg1, reg2, ptr, val > @@ -48,12 +48,14 @@ > .endm > .macro stp1 reg1, reg2, ptr, val > - user_stp 9998f, \reg1, \reg2, \ptr, \val > + user_stp 9997f, \reg1, \reg2, \ptr, \val > .endm > end .req x5 > +srcin .req x15 > SYM_FUNC_START(__arch_copy_to_user) > add end, x0, x2 > + mov srcin, x1 > #include "copy_template.S" > mov x0, #0 > ret > @@ -62,6 +64,12 @@ EXPORT_SYMBOL(__arch_copy_to_user) > .section .fixup,"ax" > .align 2 > +9997: cmp dst, dstin > + b.ne 9998f > + // Before being absolutely sure we couldn't copy anything, try harder > + ldrb tmp1w, [srcin] > +USER(9998f, sttrb tmp1w, [dstin]) > + add dst, dstin, #1 > 9998: sub x0, end, dst // bytes not copied > ret > .previous I think it's worth doing the copy_to_user() fallback in a loop until it faults or hits the end of the buffer. This would solve the problem we currently have with writing more bytes than actually reported. The copy_from_user() is not necessary, a byte would suffice. -- Catalin