From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB87C07E9C for ; Wed, 14 Jul 2021 12:37:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6273A613B0 for ; Wed, 14 Jul 2021 12:37:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6273A613B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id AAADC6B0092; Wed, 14 Jul 2021 08:37:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A34F86B0095; Wed, 14 Jul 2021 08:37:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 811726B0096; Wed, 14 Jul 2021 08:37:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0133.hostedemail.com [216.40.44.133]) by kanga.kvack.org (Postfix) with ESMTP id 5BD436B0092 for ; Wed, 14 Jul 2021 08:37:56 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E22BE2BFB0 for ; Wed, 14 Jul 2021 12:37:54 +0000 (UTC) X-FDA: 78361145268.08.8F5CB67 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf28.hostedemail.com (Postfix) with ESMTP id 9447C90000AD for ; Wed, 14 Jul 2021 12:37:54 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 64E6E613C3; Wed, 14 Jul 2021 12:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626266274; bh=DGdlwCkZIlF7M2e5FrRY4R5tomviE45g2fM8RW577bo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P0AmCcOQg+Qu6zi4j2J9dm1OfCK4LkYH8OZGagz34TNSbAJyCp6C27ALPh+cMA0fF l51XnU/CogMZ0jxfjFcPYM0c5F5MyEU6xN63vTgIZv3mnunj1Jfv4vb9MSr6SzXjPo d9CpzIXZ0OWyGCPw0x9LNc9+Muvl51p1Zz/oWHiDJKw8lGWFthmUf7ssedrY+s1sLq 6NxSjMNHJsSMwZPRlhRc68+U4mqP0tgJcL/4Yuvpnk+yDXcrZJbBnKCaHD3l988B9+ 6xtPbkwVlnfutCmyUDwk5HXV9CBpmfNvAAIQdPZE+4a3ujeXHRpEP1E3ZPHQ5E30NT ttRrd6cThDo2A== From: Mike Rapoport To: Andrew Morton Cc: Michal Simek , Mike Rapoport , Mike Rapoport , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH 4/4] memblock: stop poisoning raw allocations Date: Wed, 14 Jul 2021 15:37:39 +0300 Message-Id: <20210714123739.16493-5-rppt@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20210714123739.16493-1-rppt@kernel.org> References: <20210714123739.16493-1-rppt@kernel.org> MIME-Version: 1.0 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P0AmCcOQ; spf=pass (imf28.hostedemail.com: domain of rppt@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: 6e6bqfs7hctr18wj9bhqiw7uspm9ddhg X-Rspamd-Queue-Id: 9447C90000AD X-Rspamd-Server: rspam01 X-HE-Tag: 1626266274-682185 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Mike Rapoport Functions memblock_alloc_exact_nid_raw() and memblock_alloc_try_nid_raw() are intended for early memory allocation without overhead of zeroing the allocated memory. Since these functions were used to allocate the memory map, they have ended up with addition of a call to page_init_poison() tha= t poisoned the allocated memory when CONFIG_PAGE_POISON was set. Since the memory map is allocated using a dedicated memmep_alloc() functi= on that takes care of the poisoning, remove page poisoning from the memblock_alloc_*_raw() functions. Signed-off-by: Mike Rapoport --- mm/memblock.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index 0041ff62c584..9748d0689f81 100644 --- a/mm/memblock.c +++ b/mm/memblock.c @@ -1490,18 +1490,12 @@ void * __init memblock_alloc_exact_nid_raw( phys_addr_t min_addr, phys_addr_t max_addr, int nid) { - void *ptr; - memblock_dbg("%s: %llu bytes align=3D0x%llx nid=3D%d from=3D%pa max_add= r=3D%pa %pS\n", __func__, (u64)size, (u64)align, nid, &min_addr, &max_addr, (void *)_RET_IP_); =20 - ptr =3D memblock_alloc_internal(size, align, - min_addr, max_addr, nid, true); - if (ptr && size > 0) - page_init_poison(ptr, size); - - return ptr; + return memblock_alloc_internal(size, align, min_addr, max_addr, nid, + true); } =20 /** @@ -1528,18 +1522,12 @@ void * __init memblock_alloc_try_nid_raw( phys_addr_t min_addr, phys_addr_t max_addr, int nid) { - void *ptr; - memblock_dbg("%s: %llu bytes align=3D0x%llx nid=3D%d from=3D%pa max_add= r=3D%pa %pS\n", __func__, (u64)size, (u64)align, nid, &min_addr, &max_addr, (void *)_RET_IP_); =20 - ptr =3D memblock_alloc_internal(size, align, - min_addr, max_addr, nid, false); - if (ptr && size > 0) - page_init_poison(ptr, size); - - return ptr; + return memblock_alloc_internal(size, align, min_addr, max_addr, nid, + false); } =20 /** --=20 2.28.0