From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9ACD5C11F66 for ; Wed, 14 Jul 2021 13:46:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43A7F613C0 for ; Wed, 14 Jul 2021 13:46:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43A7F613C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 521E96B0036; Wed, 14 Jul 2021 09:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D1926B0071; Wed, 14 Jul 2021 09:46:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 372A36B0083; Wed, 14 Jul 2021 09:46:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 0BB316B0036 for ; Wed, 14 Jul 2021 09:46:39 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EBEBE1853BC9A for ; Wed, 14 Jul 2021 13:46:37 +0000 (UTC) X-FDA: 78361318434.28.CAF857F Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by imf05.hostedemail.com (Postfix) with ESMTP id B9775500C218 for ; Wed, 14 Jul 2021 13:46:37 +0000 (UTC) Received: by mail-il1-f178.google.com with SMTP id z1so1656444ils.0 for ; Wed, 14 Jul 2021 06:46:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=bylNDni7LUKM7pnvITfXsrZTIr6B2PAmOuvv1NHx8Os=; b=DgYhNMy+8lZR4sA9BJg/ytltmWZ+rtwIE+/5XTupI5sG4VIiVU74FysH95AI4uZvfl 2tc1dPKZPi4bufNTgyDmhYMCimLVwZ/j3gZ5xbYMKKRVlWZQCvV6XpcmtmWk0qXmYYsp YeD17JvHbv4cIb2uPE55pbZ1KwvtZIfxlSx5qJfyo0xuYTKC0ijub+44j+deGZNzOOv/ p9HrkSOGOTgYK1JqcXe5ycfJESOv0PcKtpbvNaMtVPrStp4gM9QfwmRJxPaFwSw6NtQD fVEAOOsUE+gVe+m7AKSr9PfqMcheGXy7VXpQ03Wf3NvEnomUYQL3rda0kbvajergcISy 37AQ== X-Gm-Message-State: AOAM53391F9+x1100dj6E6yLy0r0Zt+9MwAHqTlBPoi0qVjW9elR1Rnz 9FKhYF2q0QR1K8yYnNdo/g== X-Google-Smtp-Source: ABdhPJwzly6VLXsrTTboxhXnHeZCdEuUQxDBu27t3pSa2+1X8fR4x8BA5P9eHwkkY5vz+JeKbPGq8A== X-Received: by 2002:a92:8712:: with SMTP id m18mr6301471ild.132.1626270397009; Wed, 14 Jul 2021 06:46:37 -0700 (PDT) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id t8sm1178729iog.21.2021.07.14.06.46.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jul 2021 06:46:36 -0700 (PDT) Received: (nullmailer pid 2452887 invoked by uid 1000); Wed, 14 Jul 2021 13:46:32 -0000 Date: Wed, 14 Jul 2021 07:46:32 -0600 From: Rob Herring To: Geert Uytterhoeven Cc: Russell King , Nicolas Pitre , Ard Biesheuvel , Linus Walleij , Catalin Marinas , Will Deacon , Nick Kossifidis , Paul Walmsley , Palmer Dabbelt , Albert Ou , Frank Rowand , Dave Young , Mike Rapoport , Baoquan He , Vivek Goyal , Andrew Morton , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kexec@lists.infradead.org, linux-mm@kvack.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 01/10] crash_dump: Make elfcorehdr_{addr,size} always visible Message-ID: <20210714134632.GA2441138@robh.at.kernel.org> References: <0721f629d5e75b7b7e655458a63cbd767baaa409.1626266516.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0721f629d5e75b7b7e655458a63cbd767baaa409.1626266516.git.geert+renesas@glider.be> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B9775500C218 X-Stat-Signature: puhan61edf6979gb4df85mqzeqpejyx5 Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of robherring2@gmail.com designates 209.85.166.178 as permitted sender) smtp.mailfrom=robherring2@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) X-HE-Tag: 1626270397-266625 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 14, 2021 at 02:50:11PM +0200, Geert Uytterhoeven wrote: > Make the forward declarations of elfcorehdr_addr and elfcorehdr_size > always available, like is done for phys_initrd_start and > phys_initrd_size. Code referring to these symbols can then just check > for IS_ENABLED(CONFIG_CRASH_DUMP), instead of requiring conditional > compilation using an #ifdef, thus preparing to increase compile > coverage. > > Suggested-by: Rob Herring > Signed-off-by: Geert Uytterhoeven > --- > v4: > - New. > --- > include/linux/crash_dump.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index a5192b718dbe4f9a..ad31893d13d634de 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -10,13 +10,14 @@ > > #include /* for pgprot_t */ > > +/* For IS_ENABLED(CONFIG_CRASH_DUMP) */ > +extern unsigned long long elfcorehdr_addr; > +extern unsigned long long elfcorehdr_size; > + > #ifdef CONFIG_CRASH_DUMP > #define ELFCORE_ADDR_MAX (-1ULL) > #define ELFCORE_ADDR_ERR (-2ULL) Seems like these could be needed and no need to hide them, so perhaps just move the #ifdef down. > > -extern unsigned long long elfcorehdr_addr; > -extern unsigned long long elfcorehdr_size; > - > extern int elfcorehdr_alloc(unsigned long long *addr, unsigned long long *size); > extern void elfcorehdr_free(unsigned long long addr); > extern ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos); > -- > 2.25.1 > >