From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C35C07E96 for ; Thu, 15 Jul 2021 05:26:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 036D5610C7 for ; Thu, 15 Jul 2021 05:26:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 036D5610C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 54A4F8D008C; Thu, 15 Jul 2021 01:26:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5217E8D0065; Thu, 15 Jul 2021 01:26:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E9838D008C; Thu, 15 Jul 2021 01:26:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 1B3A28D0065 for ; Thu, 15 Jul 2021 01:26:07 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0675A824556B for ; Thu, 15 Jul 2021 05:26:06 +0000 (UTC) X-FDA: 78363685932.09.2070C74 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id BBC8550000A2 for ; Thu, 15 Jul 2021 05:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=0j89Y9aRfbS0Rk8ILDg18YHesTGwlxkjEArXWx9pLdg=; b=rtZ8plYfg2O2vQnMqCcN8Ix1eV 0XJ3QSThuBsUacVKOjdcIEAp2lxqyCZfpWvfL3hS76LBjhmK4tzKQWTC+ibKYHQbVguyCr3NUCT/l PfiDy86CIphQ+viU7oNBndb1wti75NmlHC6gxm1d+t1Cee2mwhtd/5LFKF1TA7HA4/TBS5bfjsZBK B9GlLpfAAYV2XjdDz31IcMs6Ff/yg+qAPAiXiogB7y4H3S19Ap1QH+jLHS2AQiTBQ2T0KDtCjUZwJ ns8WUYvvrwBXkKxngBqKxGgMunIOwXrWcWD/izHm4xbuTwdbZ78ZPrjccbmsd4s/WgKzPl7y51run ct8aCKMw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3tqn-00312o-KS; Thu, 15 Jul 2021 05:24:07 +0000 From: "Matthew Wilcox (Oracle)" To: linux-kernel@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v14 133/138] mm: Fix READ_ONLY_THP warning Date: Thu, 15 Jul 2021 04:36:59 +0100 Message-Id: <20210715033704.692967-134-willy@infradead.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210715033704.692967-1-willy@infradead.org> References: <20210715033704.692967-1-willy@infradead.org> MIME-Version: 1.0 Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rtZ8plYf; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none X-Stat-Signature: xm4fu9n6bnhfbkpuz49qxizio95yba3f X-Rspamd-Queue-Id: BBC8550000A2 X-Rspamd-Server: rspam01 X-HE-Tag: 1626326765-422890 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: These counters only exist if CONFIG_READ_ONLY_THP_FOR_FS is defined, but we should not warn if the filesystem natively supports THPs. Signed-off-by: Matthew Wilcox (Oracle) --- include/linux/pagemap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h index 25b1bf3b1cdb..81cccb708df7 100644 --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -146,7 +146,7 @@ static inline void filemap_nr_thps_inc(struct address= _space *mapping) if (!mapping_thp_support(mapping)) atomic_inc(&mapping->nr_thps); #else - WARN_ON_ONCE(1); + WARN_ON_ONCE(!mapping_thp_support(mapping)); #endif } =20 @@ -156,7 +156,7 @@ static inline void filemap_nr_thps_dec(struct address= _space *mapping) if (!mapping_thp_support(mapping)) atomic_dec(&mapping->nr_thps); #else - WARN_ON_ONCE(1); + WARN_ON_ONCE(!mapping_thp_support(mapping)); #endif } =20 --=20 2.30.2