From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CD95C07E95 for ; Fri, 16 Jul 2021 08:11:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B9D7F613ED for ; Fri, 16 Jul 2021 08:11:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9D7F613ED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E2E6F8D00F4; Fri, 16 Jul 2021 04:11:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDE528D00EC; Fri, 16 Jul 2021 04:11:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7EDD8D00F4; Fri, 16 Jul 2021 04:11:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0224.hostedemail.com [216.40.44.224]) by kanga.kvack.org (Postfix) with ESMTP id A67CB8D00EC for ; Fri, 16 Jul 2021 04:11:31 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 797C3824805A for ; Fri, 16 Jul 2021 08:11:30 +0000 (UTC) X-FDA: 78367731540.34.A690BEF Received: from outbound-smtp18.blacknight.com (outbound-smtp18.blacknight.com [46.22.139.245]) by imf29.hostedemail.com (Postfix) with ESMTP id 731609002595 for ; Fri, 16 Jul 2021 08:07:34 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp18.blacknight.com (Postfix) with ESMTPS id C238C1C4519 for ; Fri, 16 Jul 2021 09:07:32 +0100 (IST) Received: (qmail 22557 invoked from network); 16 Jul 2021 08:07:32 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.255]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 16 Jul 2021 08:07:32 -0000 Date: Fri, 16 Jul 2021 09:07:30 +0100 From: Mel Gorman To: Michal Such?nek Cc: Andrii Nakryiko , Andrew Morton , Christoph Hellwig , Arnaldo Carvalho de Melo , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , LKML , Jiri Olsa , Hritik Vijay , Linux-BPF , Linux-Net , Linux-MM , clm@fb.com Subject: Re: [PATCH v3] mm/page_alloc: Require pahole v1.22 to cope with zero-sized struct pagesets Message-ID: <20210716080730.GU3809@techsingularity.net> References: <20210527171923.GG30378@techsingularity.net> <20210528074248.GI30378@techsingularity.net> <20210531093554.GT30378@techsingularity.net> <20210715194453.GI24916@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20210715194453.GI24916@kitsune.suse.cz> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf29.hostedemail.com; dkim=none; spf=pass (imf29.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.245 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none X-Stat-Signature: wzj9zyyufgwnhw564s6odxkk5yosiqcq X-Rspamd-Queue-Id: 731609002595 X-Rspamd-Server: rspam01 X-HE-Tag: 1626422854-594951 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 15, 2021 at 09:44:53PM +0200, Michal Such?nek wrote: > > > Well, luckily it seems we anticipated issues like that and added > > > --skip_encoding_btf_vars argument, which I completely forgot about and > > > just accidentally came across reviewing Arnaldo's latest pahole patch. > > > I think that one is a much better solution, as then it will impact > > > only those that explicitly relies on availability of BTF for per-CPU > > > variables, which is a subset of all possible uses for kernel BTF. Sent > > > a patch ([0]), please take a look. > > > > > > [0] https://lore.kernel.org/linux-mm/20210530002536.3193829-1-andrii@kernel.org/T/#u > > > > I'm happy to have this patch used as an alternative to forcing 1.22 to > > be the minimum version of pahole required. > > Is pahole 1.22 available already? > Ultimately it was of less importance because of a0b8200d06ad ("kbuild: skip per-CPU BTF generation for pahole v1.18-v1.21"). As I write this, pahole v1.22 has not been tagged. -- Mel Gorman SUSE Labs