From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAD9CC07E9B for ; Tue, 20 Jul 2021 23:14:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 38FDE60FF3 for ; Tue, 20 Jul 2021 23:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38FDE60FF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D8CC96B0011; Tue, 20 Jul 2021 19:14:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D13F06B0036; Tue, 20 Jul 2021 19:14:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8D656B006C; Tue, 20 Jul 2021 19:14:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 893456B0011 for ; Tue, 20 Jul 2021 19:14:27 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0CD9A22BF4 for ; Tue, 20 Jul 2021 23:14:26 +0000 (UTC) X-FDA: 78384522132.07.E5C395C Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP id 707AFF002CAF for ; Tue, 20 Jul 2021 23:14:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 46CB760FE7; Tue, 20 Jul 2021 23:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1626822862; bh=nEnjKOxUloIQfSQL7a+2WVoIz2kHnvdbpqmipDdcQII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=asJZYUWGeUCXEMHNcgGFRAG/YdCc5ucna4fYThfnH6elAMAExzgEYCremlJelES1R H5xyNCRFILz36ZhahLc4oktKOkbnRMklrUbRAAoEoF0z7gFZAq+pw8H77B9yvDx1zw /nukVTRmXzzte9RPc7RrDPONIP+pA3r9KNH85Loo= Date: Tue, 20 Jul 2021 16:14:21 -0700 From: Andrew Morton To: Qi Zheng Cc: "Kirill A. Shutemov" , tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH 1/7] mm: fix the deadlock in finish_fault() Message-Id: <20210720161421.f4874db77e0b13192d0ab895@linux-foundation.org> In-Reply-To: <9e97cedc-9fd7-4290-9f44-04b96acea15d@bytedance.com> References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-2-zhengqi.arch@bytedance.com> <20210718212814.suvziikndiyezi6m@box.shutemov.name> <9e97cedc-9fd7-4290-9f44-04b96acea15d@bytedance.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf17.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=linux-foundation.org header.s=korg header.b=asJZYUWG; spf=temperror (imf17.hostedemail.com: error in processing during lookup of akpm@linux-foundation.org: DNS error) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam05 X-Stat-Signature: 89jzj9yraoj5q38kt4i85pw4fr5hctmx X-Rspamd-Queue-Id: 707AFF002CAF X-HE-Tag: 1626822865-131802 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 19 Jul 2021 17:53:12 +0800 Qi Zheng wrote: > > > On 7/19/21 5:28 AM, Kirill A. Shutemov wrote: > > On Sun, Jul 18, 2021 at 12:30:27PM +0800, Qi Zheng wrote: > >> The commit 63f3655f9501(mm, memcg: fix reclaim deadlock with writeback) > >> fix a deadlock bug by pre-allocating the pte page table outside of the > >> page lock, the commit f9ce0be71d1f(mm: Cleanup faultaround and > >> finish_fault() codepaths) rework the relevant code but ignore this race, > >> fix it. > >> > >> Fixes: f9ce0be71d1f(mm: Cleanup faultaround and finish_fault() codepaths) > >> Signed-off-by: Qi Zheng > > > > Acked-by: Kirill A. Shutemov > > > > and add stable@, please. > > > > OK, I will add these in the patch v2, thanks. Please send this as a separate standalone patch, not as a part of the main series. Also, please include in the changelog a description of the user-visible impact of the bug which is being fixed.