From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D73D1C07E9B for ; Wed, 21 Jul 2021 00:02:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EC596101B for ; Wed, 21 Jul 2021 00:02:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EC596101B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 137F06B0011; Tue, 20 Jul 2021 20:02:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10DE06B0036; Tue, 20 Jul 2021 20:02:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F17E36B006C; Tue, 20 Jul 2021 20:02:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id CF5AD6B0011 for ; Tue, 20 Jul 2021 20:02:28 -0400 (EDT) Received: from smtpin40.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 4E3A9184F4E93 for ; Wed, 21 Jul 2021 00:02:27 +0000 (UTC) X-FDA: 78384643134.40.74F36B9 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP id 029416001993 for ; Wed, 21 Jul 2021 00:02:26 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9370061019; Wed, 21 Jul 2021 00:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626825744; bh=92Gjrop0XLyAuerlYU5OBiO3OpCjgEbq8pXa4g95YMg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HSEsFujMopdUvp/8h/Vc0fIoUMksjU9jfdH9FvJoEO7G/eylKh7A35iPv8fZOQq0p +7MVyZZ72wnBFkYD9qVLyS+7p2f/3yRzQkG+Kh9R+45N+Rcllur2A9iHsvFVLQJ18r rSFuT5t3tYnmCZubOLS0HgLwJd/+77CNDCS2OYMFcSlhOYaUL288u3RwfRfZmuvv5I AXyjMxXp8RvrV9Xa02Oz42YzOWMrHxUpoeWKBeHawB6v70VDFGqoq9QXS/5GeBQ4z6 as5XpKOVLB7hyc9wUeduPF7u/OoY2LE9Vm6tX363ql0sy1Nm2f/0775xk71coepC1F Xh7d+IHGYJzXA== Date: Tue, 20 Jul 2021 17:02:24 -0700 From: "Darrick J. Wong" To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org Subject: Re: [PATCH v15 17/17] iomap: Convert iomap_migrate_page to use folios Message-ID: <20210721000224.GQ22357@magnolia> References: <20210719184001.1750630-1-willy@infradead.org> <20210719184001.1750630-18-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210719184001.1750630-18-willy@infradead.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 029416001993 X-Stat-Signature: h3cgtcpmnihs4y1zgepkindw1g3z5ypd Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HSEsFujM; spf=pass (imf10.hostedemail.com: domain of djwong@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djwong@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1626825746-929808 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 19, 2021 at 07:40:01PM +0100, Matthew Wilcox (Oracle) wrote: > The arguments are still pages for now, but we can use folios internally > and cut out a lot of calls to compound_head(). > > Signed-off-by: Matthew Wilcox (Oracle) Didn't I RVb this last time? ;) Reviewed-by: Darrick J. Wong --D > --- > fs/iomap/buffered-io.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c > index 60d3b7af61d1..cf56b19fb101 100644 > --- a/fs/iomap/buffered-io.c > +++ b/fs/iomap/buffered-io.c > @@ -492,19 +492,21 @@ int > iomap_migrate_page(struct address_space *mapping, struct page *newpage, > struct page *page, enum migrate_mode mode) > { > + struct folio *folio = page_folio(page); > + struct folio *newfolio = page_folio(newpage); > int ret; > > - ret = migrate_page_move_mapping(mapping, newpage, page, 0); > + ret = folio_migrate_mapping(mapping, newfolio, folio, 0); > if (ret != MIGRATEPAGE_SUCCESS) > return ret; > > - if (page_has_private(page)) > - attach_page_private(newpage, detach_page_private(page)); > + if (folio_test_private(folio)) > + folio_attach_private(newfolio, folio_detach_private(folio)); > > if (mode != MIGRATE_SYNC_NO_COPY) > - migrate_page_copy(newpage, page); > + folio_migrate_copy(newfolio, folio); > else > - migrate_page_states(newpage, page); > + folio_migrate_flags(newfolio, folio); > return MIGRATEPAGE_SUCCESS; > } > EXPORT_SYMBOL_GPL(iomap_migrate_page); > -- > 2.30.2 >