From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4BEC4320A for ; Mon, 2 Aug 2021 08:26:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 81BAC610A2 for ; Mon, 2 Aug 2021 08:26:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 81BAC610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 103318D0001; Mon, 2 Aug 2021 04:26:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B23D6B0036; Mon, 2 Aug 2021 04:26:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE3E48D0001; Mon, 2 Aug 2021 04:26:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id D6B306B0033 for ; Mon, 2 Aug 2021 04:26:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 89F9A18EE6 for ; Mon, 2 Aug 2021 08:26:21 +0000 (UTC) X-FDA: 78429458562.30.5128965 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 152D3D0013AA for ; Mon, 2 Aug 2021 08:26:20 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id a26so32212161lfr.11 for ; Mon, 02 Aug 2021 01:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kz70ZSfw0gF/+Eh/YJkSF3/zSs7YIozU2Kk7aShS8/8=; b=J5xAHujnzexFvkkaoEUTfQIY3kAfoX3t0epqE64o+NeLDaqffL2McvcjUUxw2ktQY7 hq1E6o9GZ/ylYc3n6snTUXx8AnF+RKXZ9lAKxmM5HDmf83z/7B6YEyTs//qYuxKAa6dZ bEJH6KNuLOf1wy7fYK22finBSH/SV7Ds+XeVfwiJJACQJHs4ERQg3gYHwNRm9X+mRL6Y /0tozTp22V26v4/JQKKeDj8ZFY+Pb4bX1pYHZVSE3r8Ok43kmkwDlsDXUrYG7jwC4Uba JzJUSDBcpFT+S/hNuHDbo/L8+V7thyZzJPIdqFsRp3PCMt71hTrIDtdQNTjKXjZFvyvp a0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kz70ZSfw0gF/+Eh/YJkSF3/zSs7YIozU2Kk7aShS8/8=; b=n131svR//y5Zc372bnNNTjxnKr8+vMBzPA9g5EFd6PFV+zLAXoDgGf7QTFXq5n/B3f Cp91ebdYu4rolLXNb79WmM0tI+TJkmeRIH4PtoQsCA1YCGYB3zn90eRaOCxyHIokhWZJ YmvnXFlpqfrt1hbTC3Wi2viQf18cC2b/fbcU91Ep3zpCqtBJsHhRdJ7TGKjRor8kvXzu j9TnvFtgL8uAggaH/IdnqbzQXUK/M9wbdMmfXVOnn4nA0WoJco5SAuXLon5MsQttnvFM +bmTFzFFMRRw/sxGGx2TdVxlSMorjxmpvsbXGLCPXQ7bnvcMpnFSJ05dmL1b5ZbJHyaR jNQA== X-Gm-Message-State: AOAM530t+iDilDlabXlB93HM+AN7r0KtcQWM1gMVYwS5d5aQbxLux1HN W1bVD7QXBsbxEW+VVSwyWWP3Lw== X-Google-Smtp-Source: ABdhPJw4L1rfWJyd67FPpqtde+HLzdTeW90cWbvOk2oF2MTjUInXvrFZCt9sc56KfGp6ReXUQE5Rzw== X-Received: by 2002:a05:6512:1689:: with SMTP id bu9mr4154164lfb.147.1627892779032; Mon, 02 Aug 2021 01:26:19 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r11sm840514ljp.135.2021.08.02.01.26.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 01:26:18 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id 067C3102B6D; Mon, 2 Aug 2021 11:26:22 +0300 (+03) Date: Mon, 2 Aug 2021 11:26:21 +0300 From: "Kirill A. Shutemov" To: Mike Rapoport Cc: Andrew Morton , Albert Ou , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Christian Borntraeger , Dave Hansen , Frank Rowand , Greg Kroah-Hartman , "H. Peter Anvin" , Heiko Carstens , Ingo Molnar , Len Brown , Marc Zyngier , Mike Rapoport , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rob Herring , Russell King , Thomas Bogendoerfer , Thomas Gleixner , Vasily Gorbik , Will Deacon , devicetree@vger.kernel.org, kvmarm@lists.cs.columbia.edu, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2] memblock: make memblock_find_in_range method private Message-ID: <20210802082621.xfbrdg2c6glwz3oq@box.shutemov.name> References: <20210802063737.22733-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210802063737.22733-1-rppt@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 152D3D0013AA Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=J5xAHujn; dmarc=none; spf=none (imf20.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.47) smtp.mailfrom=kirill@shutemov.name X-Stat-Signature: wgw3f9kf3f558f4x9poou4hr1rqw8k1s X-HE-Tag: 1627892780-135092 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 02, 2021 at 09:37:37AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > There are a lot of uses of memblock_find_in_range() along with > memblock_reserve() from the times memblock allocation APIs did not exist. > > memblock_find_in_range() is the very core of memblock allocations, so any > future changes to its internal behaviour would mandate updates of all the > users outside memblock. > > Replace the calls to memblock_find_in_range() with an equivalent calls to > memblock_phys_alloc() and memblock_phys_alloc_range() and make > memblock_find_in_range() private method of memblock. > > This simplifies the callers, ensures that (unlikely) errors in > memblock_reserve() are handled and improves maintainability of > memblock_find_in_range(). > > Signed-off-by: Mike Rapoport Looks good to me: Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov