From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60754C4338F for ; Thu, 12 Aug 2021 09:20:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA21A6103A for ; Thu, 12 Aug 2021 09:20:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA21A6103A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 16FA48D000D; Thu, 12 Aug 2021 05:20:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F82C8D0009; Thu, 12 Aug 2021 05:20:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F27E48D000D; Thu, 12 Aug 2021 05:20:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id D5BD88D0009 for ; Thu, 12 Aug 2021 05:20:48 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 815738249980 for ; Thu, 12 Aug 2021 09:20:48 +0000 (UTC) X-FDA: 78465883776.23.2D2BAB9 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf21.hostedemail.com (Postfix) with ESMTP id A50BCD01DC75 for ; Thu, 12 Aug 2021 09:20:47 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 8DC3A67373; Thu, 12 Aug 2021 11:20:44 +0200 (CEST) Date: Thu, 12 Aug 2021 11:20:43 +0200 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , LKML , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , Matthew Wilcox Subject: Re: [PATCH v2 2/3] mm/gup: small refactoring: simplify try_grab_page() Message-ID: <20210812092043.GA4827@lst.de> References: <20210811070542.3403116-1-jhubbard@nvidia.com> <20210811070542.3403116-3-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210811070542.3403116-3-jhubbard@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=none (imf21.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A50BCD01DC75 X-Stat-Signature: s5p1ea1g1aosrwy5otn6fziaox9hckcj X-HE-Tag: 1628760047-847559 X-Bogosity: Ham, tests=bogofilter, spamicity=0.005415, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Looks good, Reviewed-by: Christoph Hellwig Note: the __maybe_unused on try_grab_compound_head should be dropped now that there is always a user.