From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9676DC432BE for ; Thu, 12 Aug 2021 20:19:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3729A6101E for ; Thu, 12 Aug 2021 20:19:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3729A6101E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 9D10C8D0002; Thu, 12 Aug 2021 16:19:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9803C8D0001; Thu, 12 Aug 2021 16:19:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896768D0002; Thu, 12 Aug 2021 16:19:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0058.hostedemail.com [216.40.44.58]) by kanga.kvack.org (Postfix) with ESMTP id 752138D0001 for ; Thu, 12 Aug 2021 16:19:26 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1B2A61825FC4A for ; Thu, 12 Aug 2021 20:19:26 +0000 (UTC) X-FDA: 78467543532.36.1853246 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf26.hostedemail.com (Postfix) with ESMTP id BDB2D2016565 for ; Thu, 12 Aug 2021 20:19:25 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id AC44B6101E; Thu, 12 Aug 2021 20:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1628799564; bh=Met7BhuqN1q9Po3dqJQJ6Y0ovIYXHRZjV39nyIWR2KY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MHlUhKi3mZoE9MhFJwD6k376NqkGX3yv1mGuBfyiWDaFkimvMJ4XLGvJurLQFvCSw xJ42KQGRuWpefErVY7wS7Xy93VJ+Z6ihqAsNfczrle46YuuX4b70aWb0Yvb3eZl0GZ +u1c8rNyWDP6ZDc5aU0heOiQ5vLJABtPDUcp8bxg= Date: Thu, 12 Aug 2021 13:19:21 -0700 From: Andrew Morton To: SeongJae Park Cc: =?UTF-8?Q?"Valdis_Kl=C4=93tnieks"?= , SeongJae Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: Message-Id: <20210812131921.a1c5c85213290e1729cc72a3@linux-foundation.org> In-Reply-To: <20210812094240.4492-1-sjpark@amazon.de> References: <144813.1628760117@turing-police> <20210812094240.4492-1-sjpark@amazon.de> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=MHlUhKi3; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BDB2D2016565 X-Stat-Signature: gdwaecgms6ef8us6qtgo1em38odkebja X-HE-Tag: 1628799565-963027 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 12 Aug 2021 09:42:40 +0000 SeongJae Park wrote: > > +config PAGE_IDLE_FLAG > > + bool "Add PG_idle and PG_young flags" > > + help > > + This feature adds PG_idle and PG_young flags in 'struct page'. PTE > > + Accessed bit writers can set the state of the bit in the flags to let > > + other PTE Accessed bit readers don't disturbed. > > > > This needs to be converted to proper, or at least comprehensible, English.... > > Thank you for the comment. > > How about below? > > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -743,9 +743,9 @@ config PAGE_IDLE_FLAG > bool "Add PG_idle and PG_young flags" > select PAGE_EXTENSION if !64BIT > help > - This feature adds PG_idle and PG_young flags in 'struct page'. PTE > - Accessed bit writers can set the state of the bit in the flags to let > - other PTE Accessed bit readers don't disturbed. > + This feature adds 'PG_idle' and 'PG_young' flags in 'struct page'. > + PTE Accessed bit writers can save the state of the bit in the flags > + to let other PTE Accessed bit readers don't get disturbed. How about this? --- a/mm/Kconfig~mm-idle_page_tracking-make-pg_idle-reusable-fix-fix +++ a/mm/Kconfig @@ -743,9 +743,9 @@ config PAGE_IDLE_FLAG bool "Add PG_idle and PG_young flags" select PAGE_EXTENSION if !64BIT help - This feature adds PG_idle and PG_young flags in 'struct page'. PTE - Accessed bit writers can set the state of the bit in the flags to let - other PTE Accessed bit readers don't disturbed. + This adds PG_idle and PG_young flags to 'struct page'. PTE Accessed + bit writers can set the state of the bit in the flags so that PTE + Accessed bit readers may avoid disturbance. config IDLE_PAGE_TRACKING bool "Enable idle page tracking" Also, is there any way in which we can avoid presenting this option to the user? Because most users will have real trouble understanding what this thing is for. Can we simply select it when needed, as dictated by other, higher-level config options?