From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C978C4320A for ; Sun, 15 Aug 2021 09:01:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4CE361055 for ; Sun, 15 Aug 2021 09:01:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A4CE361055 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id F2DC18D000C; Sun, 15 Aug 2021 05:01:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDE668D0005; Sun, 15 Aug 2021 05:01:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DF4A18D000C; Sun, 15 Aug 2021 05:01:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id C105C8D0005 for ; Sun, 15 Aug 2021 05:01:05 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 53DAC1E4E9 for ; Sun, 15 Aug 2021 09:01:05 +0000 (UTC) X-FDA: 78476720490.07.9180B85 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id A7951E0085E1 for ; Sun, 15 Aug 2021 09:01:04 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 686D56736F; Sun, 15 Aug 2021 11:01:01 +0200 (CEST) Date: Sun, 15 Aug 2021 11:01:00 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v6 01/13] ext4/xfs: add page refcount helper Message-ID: <20210815090100.GA25067@lst.de> References: <20210813063150.2938-1-alex.sierra@amd.com> <20210813063150.2938-2-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813063150.2938-2-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: A7951E0085E1 Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=none (imf30.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam04 X-Stat-Signature: rartadtt31xrjyo67mb7oab9rhcxbopt X-HE-Tag: 1629018064-461383 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 13, 2021 at 01:31:38AM -0500, Alex Sierra wrote: > From: Ralph Campbell > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > v3: > [AS]: rename dax_layout_is_idle_page func to dax_page_unused > > v4: > [AS]: This ref count functionality was missing on fuse/dax.c. These per-patch changelog goes under the "---", otherwise they totally mess up the logs when commited to git. Same for the other patches in this series. But the changes itself looks good: Reviewed-by: Christoph Hellwig