From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CC02C4320A for ; Sun, 15 Aug 2021 09:19:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CBC806103D for ; Sun, 15 Aug 2021 09:19:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CBC806103D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 667046B006C; Sun, 15 Aug 2021 05:19:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 617C08D0002; Sun, 15 Aug 2021 05:19:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 537E76B0073; Sun, 15 Aug 2021 05:19:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0166.hostedemail.com [216.40.44.166]) by kanga.kvack.org (Postfix) with ESMTP id 37B536B006C for ; Sun, 15 Aug 2021 05:19:39 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B791C181AF5EA for ; Sun, 15 Aug 2021 09:19:38 +0000 (UTC) X-FDA: 78476767236.01.B09E868 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf25.hostedemail.com (Postfix) with ESMTP id 68D2CB002589 for ; Sun, 15 Aug 2021 09:19:38 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 2576E6736F; Sun, 15 Aug 2021 11:19:36 +0200 (CEST) Date: Sun, 15 Aug 2021 11:19:35 +0200 From: Christoph Hellwig To: Alex Sierra Cc: akpm@linux-foundation.org, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jgg@nvidia.com, jglisse@redhat.com Subject: Re: [PATCH v6 07/13] mm: add generic type support to migrate_vma helpers Message-ID: <20210815091935.GD25067@lst.de> References: <20210813063150.2938-1-alex.sierra@amd.com> <20210813063150.2938-8-alex.sierra@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210813063150.2938-8-alex.sierra@amd.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 68D2CB002589 Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=none (imf25.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam04 X-Stat-Signature: zxr9kg9mdm1dcqgewo5xq7ihnpap4ta4 X-HE-Tag: 1629019178-914914 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 13, 2021 at 01:31:44AM -0500, Alex Sierra wrote: > Device generic type case added for migrate_vma_pages and > migrate_vma_check_page helpers. > Both, generic and private device types have the same > conditions to decide to migrate pages from/to device > memory. This reas a little weird mostly because it doesn't use up the line length nicely: Add the device generic type case to the migrate_vma_pages and migrate_vma_check_page helpers. This new case is handled identically to the existing device private case. > + * We support migrating to private and generic types for device > + * zone memory. Don't spill comments over 80 characters. Otherwise looks good: Reviewed-by: Christoph Hellwig