From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E088C432BE for ; Tue, 17 Aug 2021 09:12:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A151B60524 for ; Tue, 17 Aug 2021 09:12:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A151B60524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 27B0E6B006C; Tue, 17 Aug 2021 05:12:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B266B0072; Tue, 17 Aug 2021 05:12:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A178D0001; Tue, 17 Aug 2021 05:12:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id E99116B006C for ; Tue, 17 Aug 2021 05:12:30 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8072918411DA7 for ; Tue, 17 Aug 2021 09:12:30 +0000 (UTC) X-FDA: 78484006860.01.5CDB2FE Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by imf14.hostedemail.com (Postfix) with ESMTP id E79E46011E91 for ; Tue, 17 Aug 2021 09:12:28 +0000 (UTC) Date: Tue, 17 Aug 2021 11:12:24 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1629191546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vna3ay+6qfC6a6U/7R3m6EAXb7rtIYGsPklTZxXUqeY=; b=Iwn1N4ZzjrNzw92s+RCTec9IgmEdVl7DLCla5o3/SqiTq19vJxrd5Zc/9f4+OMPo4AgEPA OAYD3zOKnHAxZxvUSZKaynf52bSYCeAhGlTGn1Rv9ulBGt+EijzKl5b/pqQxqKumnYD/D2 ELS0zpsJi5XrNNKHmHM7a8xorkrffLimxaRDuJP+Z9A6udR87J2PBSZZ+aGnvJRlk8gUeS bLqsIoMR1OrqPWeB8L6PVDO/d+84jTRoAhsopDzqfCCMFVsEiaOA3MTahAUZOg652sHqej b5IETeIAE4DhCBosKePMIVXYDuXEqoMJePr1QwzGoaFTxGelEOUj6wiO6Wne7A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1629191546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Vna3ay+6qfC6a6U/7R3m6EAXb7rtIYGsPklTZxXUqeY=; b=pOyfrq8aIKWTzmlthQ2kwy0IlXHm+1Ghsxpzs6vbG40odt18B9tJSkmGyg/iv7HcW5GQF5 M3Z2Y5QSfIMRAMDA== From: Sebastian Andrzej Siewior To: Vlastimil Babka Cc: Sven Eckelmann , akpm@linux-foundation.org, brouer@redhat.com, cl@linux.com, efault@gmx.de, iamjoonsoo.kim@lge.com, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mgorman@techsingularity.net, penberg@kernel.org, rientjes@google.com, tglx@linutronix.de, Stephen Rothwell , Peter Zijlstra Subject: Re: [PATCH v4 35/35] mm, slub: convert kmem_cpu_slab protection to local_lock Message-ID: <20210817091224.nqnrro34cyb67chj@linutronix.de> References: <2666777.vCjUEy5FO1@sven-desktop> <7329198a-2a4e-ebc2-abf8-f7f38f00d5e1@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7329198a-2a4e-ebc2-abf8-f7f38f00d5e1@suse.cz> Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linutronix.de header.s=2020 header.b=Iwn1N4Zz; dkim=pass header.d=linutronix.de header.s=2020e header.b=pOyfrq8a; spf=pass (imf14.hostedemail.com: domain of bigeasy@linutronix.de designates 193.142.43.55 as permitted sender) smtp.mailfrom=bigeasy@linutronix.de; dmarc=pass (policy=none) header.from=linutronix.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E79E46011E91 X-Stat-Signature: cmu33xb4joyg88kkcz7qf68qgoxhbxd9 X-HE-Tag: 1629191548-703816 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2021-08-17 10:37:48 [+0200], Vlastimil Babka wrote: > OK reproduced. Thanks, will investigate. With the local_lock at the top, the needed alignment gets broken for dbl cmpxchg. On RT it was working ;) diff --git a/include/linux/slub_def.h b/include/linux/slub_def.h index b5bcac29b979c..cd14aa1f9bc3c 100644 --- a/include/linux/slub_def.h +++ b/include/linux/slub_def.h @@ -42,9 +42,9 @@ enum stat_item { NR_SLUB_STAT_ITEMS }; struct kmem_cache_cpu { - local_lock_t lock; /* Protects the fields below except stat */ void **freelist; /* Pointer to next available object */ unsigned long tid; /* Globally unique transaction id */ + local_lock_t lock; /* Protects the fields below except stat */ struct page *page; /* The slab from which we are allocating */ #ifdef CONFIG_SLUB_CPU_PARTIAL struct page *partial; /* Partially allocated frozen slabs */ Sebastian