From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4311CC4338F for ; Mon, 23 Aug 2021 00:48:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 928366127B for ; Mon, 23 Aug 2021 00:48:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 928366127B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=zte.com.cn Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id A35EC8D0001; Sun, 22 Aug 2021 20:48:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E60B6B0072; Sun, 22 Aug 2021 20:48:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FBCC8D0001; Sun, 22 Aug 2021 20:48:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id 7359C6B006C for ; Sun, 22 Aug 2021 20:48:13 -0400 (EDT) Received: from smtpin35.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 15DE91802BACA for ; Mon, 23 Aug 2021 00:48:13 +0000 (UTC) X-FDA: 78504508866.35.297BE58 Received: from mxct.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by imf10.hostedemail.com (Postfix) with ESMTP id E5575600198E for ; Mon, 23 Aug 2021 00:48:11 +0000 (UTC) Received: from mse-fl2.zte.com.cn (unknown [10.30.14.239]) by Forcepoint Email with ESMTPS id 936EE462554121ED5440; Mon, 23 Aug 2021 08:48:05 +0800 (CST) Received: from kjyxapp02.zte.com.cn ([10.30.12.201]) by mse-fl2.zte.com.cn with SMTP id 17N0m1QH081533; Mon, 23 Aug 2021 08:48:01 +0800 (GMT-8) (envelope-from wang.yi59@zte.com.cn) Received: from fox-cloudhost8.localdomain (unknown [10.234.72.110]) by smtp (Zmail) with SMTP; Mon, 23 Aug 2021 08:48:01 +0800 X-Zmail-TransId: 3e886122f04001b-632b7 From: Yi Wang To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn, wang.yi59@zte.com.cn, jiang.xuexin@zte.com.cn, zealci@zte.com.cn, Changcheng Deng Subject: [PATCH linux-next] mm/folio-compat.c: folio should not be NULL when it is referenced Date: Mon, 23 Aug 2021 08:47:35 +0800 Message-Id: <20210823004735.32013-1-wang.yi59@zte.com.cn> X-Mailer: git-send-email 2.33.0.rc0.dirty MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=====_001_next=====" X-MAIL:mse-fl2.zte.com.cn 17N0m1QH081533 Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wang.yi59@zte.com.cn designates 202.103.147.172 as permitted sender) smtp.mailfrom=wang.yi59@zte.com.cn; dmarc=pass (policy=none) header.from=zte.com.cn X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E5575600198E X-Stat-Signature: 6k9tyowudnji1e8z8rdux7xg3qc46jua X-HE-Tag: 1629679691-314681 Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --=====_001_next===== Content-Type: multipart/alternative; boundary="=====_003_next=====" --=====_003_next===== Content-Type: text/plain; charset="UTF-8" From: Changcheng Deng A bug was found by coccinelle: folio is NULL but dereferenced Therefore,added a check to make sure 'folio' is not NULL. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng Signed-off-by: Yi Wang --- mm/folio-compat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/folio-compat.c b/mm/folio-compat.c index 5b6ae1d..bee45e7 100644 --- a/mm/folio-compat.c +++ b/mm/folio-compat.c @@ -123,8 +123,9 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, struct folio *folio; folio = __filemap_get_folio(mapping, index, fgp_flags, gfp); - if ((fgp_flags & FGP_HEAD) || !folio || xa_is_value(folio)) - return &folio->page; + if ((fgp_flags & FGP_HEAD) || xa_is_value(folio)) + if (folio != NULL) + return &folio->page; return folio_file_page(folio, index); } EXPORT_SYMBOL(pagecache_get_page); -- 1.8.3.1 --=====_003_next=====-- --=====_001_next=====--