From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: unexport folio_add_lru
Date: Mon, 23 Aug 2021 15:18:43 +0200 [thread overview]
Message-ID: <20210823131843.GA17513@lst.de> (raw)
In-Reply-To: <YSOe3NPBvAWeNEXO@casper.infradead.org>
On Mon, Aug 23, 2021 at 02:13:00PM +0100, Matthew Wilcox wrote:
> On Mon, Aug 23, 2021 at 02:43:07PM +0200, Christoph Hellwig wrote:
> > Only used in core mm code.
>
> Yes, but that's going to be true of virtually all the folio symbols
> which are wrapped in folio-compat.c. Perhaps we can give this one a
> year to see what the CIFS and FUSE folio conversions end up looking like?
A year before exporting something random? Yes. CIFS seems to be
mostly related to their strange ->readpages which shouldn't exist
in this form. Fuse hs some deep mm magic related to
replace_page_cache_page, which should probably deal with the LRU
as well.
prev parent reply other threads:[~2021-08-23 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 12:43 [PATCH] mm: unexport folio_add_lru Christoph Hellwig
2021-08-23 13:13 ` Matthew Wilcox
2021-08-23 13:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823131843.GA17513@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).