From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A2AC4338F for ; Mon, 23 Aug 2021 13:18:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A1BF6124D for ; Mon, 23 Aug 2021 13:18:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0A1BF6124D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 787B26B006C; Mon, 23 Aug 2021 09:18:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7103A8D0001; Mon, 23 Aug 2021 09:18:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FEBF6B0073; Mon, 23 Aug 2021 09:18:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0161.hostedemail.com [216.40.44.161]) by kanga.kvack.org (Postfix) with ESMTP id 41FAF6B006C for ; Mon, 23 Aug 2021 09:18:48 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C4AE8181AF5E6 for ; Mon, 23 Aug 2021 13:18:47 +0000 (UTC) X-FDA: 78506400294.03.7AC05C9 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf15.hostedemail.com (Postfix) with ESMTP id 4B1A3D00009D for ; Mon, 23 Aug 2021 13:18:47 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 03D8667357; Mon, 23 Aug 2021 15:18:44 +0200 (CEST) Date: Mon, 23 Aug 2021 15:18:43 +0200 From: Christoph Hellwig To: Matthew Wilcox Cc: Christoph Hellwig , akpm@linux-foundation.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: unexport folio_add_lru Message-ID: <20210823131843.GA17513@lst.de> References: <20210823124307.970182-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=none (imf15.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4B1A3D00009D X-Stat-Signature: e4ndgg3j75d7u5cq1qa998j7ez3761bu X-HE-Tag: 1629724727-998488 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 23, 2021 at 02:13:00PM +0100, Matthew Wilcox wrote: > On Mon, Aug 23, 2021 at 02:43:07PM +0200, Christoph Hellwig wrote: > > Only used in core mm code. > > Yes, but that's going to be true of virtually all the folio symbols > which are wrapped in folio-compat.c. Perhaps we can give this one a > year to see what the CIFS and FUSE folio conversions end up looking like? A year before exporting something random? Yes. CIFS seems to be mostly related to their strange ->readpages which shouldn't exist in this form. Fuse hs some deep mm magic related to replace_page_cache_page, which should probably deal with the LRU as well.