* [PATCH] mm: unexport folio_add_lru
@ 2021-08-23 12:43 Christoph Hellwig
2021-08-23 13:13 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2021-08-23 12:43 UTC (permalink / raw)
To: akpm, willy; +Cc: linux-mm
Only used in core mm code.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
mm/swap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/swap.c b/mm/swap.c
index 04b678342c020..d88895fcd26f8 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -459,7 +459,6 @@ void folio_add_lru(struct folio *folio)
__pagevec_lru_add(pvec);
local_unlock(&lru_pvecs.lock);
}
-EXPORT_SYMBOL(folio_add_lru);
/**
* lru_cache_add_inactive_or_unevictable
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: unexport folio_add_lru
2021-08-23 12:43 [PATCH] mm: unexport folio_add_lru Christoph Hellwig
@ 2021-08-23 13:13 ` Matthew Wilcox
2021-08-23 13:18 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Wilcox @ 2021-08-23 13:13 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: akpm, linux-mm
On Mon, Aug 23, 2021 at 02:43:07PM +0200, Christoph Hellwig wrote:
> Only used in core mm code.
Yes, but that's going to be true of virtually all the folio symbols
which are wrapped in folio-compat.c. Perhaps we can give this one a
year to see what the CIFS and FUSE folio conversions end up looking like?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: unexport folio_add_lru
2021-08-23 13:13 ` Matthew Wilcox
@ 2021-08-23 13:18 ` Christoph Hellwig
0 siblings, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2021-08-23 13:18 UTC (permalink / raw)
To: Matthew Wilcox; +Cc: Christoph Hellwig, akpm, linux-mm
On Mon, Aug 23, 2021 at 02:13:00PM +0100, Matthew Wilcox wrote:
> On Mon, Aug 23, 2021 at 02:43:07PM +0200, Christoph Hellwig wrote:
> > Only used in core mm code.
>
> Yes, but that's going to be true of virtually all the folio symbols
> which are wrapped in folio-compat.c. Perhaps we can give this one a
> year to see what the CIFS and FUSE folio conversions end up looking like?
A year before exporting something random? Yes. CIFS seems to be
mostly related to their strange ->readpages which shouldn't exist
in this form. Fuse hs some deep mm magic related to
replace_page_cache_page, which should probably deal with the LRU
as well.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-08-23 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-23 12:43 [PATCH] mm: unexport folio_add_lru Christoph Hellwig
2021-08-23 13:13 ` Matthew Wilcox
2021-08-23 13:18 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).