From: kernel test robot <lkp@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Colin Ian King <colin.king@canonical.com>,
Grant Grundler <grundler@chromium.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Oliver Neukum <oneukum@suse.com>,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings
Date: Wed, 25 Aug 2021 06:17:16 +0800 [thread overview]
Message-ID: <20210824221716.GA23759@2b586af07b64> (raw)
In-Reply-To: <202108250651.uuW5Q2Rg-lkp@intel.com>
From: kernel test robot <lkp@intel.com>
drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here
Remove unneeded conversion to bool
Semantic patch information:
Relational and logical operators evaluate to bool,
explicit conversion is overly verbose and unneeded.
Generated by: scripts/coccinelle/misc/boolconv.cocci
Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible")
CC: Oleksij Rempel <o.rempel@pengutronix.de>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 372b2891c15acbf7b90d948b08ac174bde77102c
commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible
:::::: branch date: 12 hours ago
:::::: commit date: 35 hours ago
asix_devices.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d
return ret;
priv->phy_addr = ret;
- priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false);
+ priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10);
asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0);
chipcode &= AX_CHIPCODE_MASK;
next prev parent reply other threads:[~2021-08-24 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 22:17 [linux-next:master 9154/10077] drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here kernel test robot
2021-08-24 22:17 ` kernel test robot [this message]
2021-08-25 4:22 ` [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings Oleksij Rempel
2021-08-25 14:29 ` Jakub Kicinski
2021-08-25 18:36 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824221716.GA23759@2b586af07b64 \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=colin.king@canonical.com \
--cc=grundler@chromium.org \
--cc=hkallweit1@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).