Re: [PATCH] MIPS: fix local_t operation on MIPS64

Maciej W. Rozycki
2021-09-04T17:58:02Z

On Sat, 4 Sep 2021, Huang Pei wrote:

> diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h
> index ec09fe5d6d6c..788e26ad7fca 100644
> --- a/arch/mips/include/asm/llsc.h
> +++ b/arch/mips/include/asm/llsc.h
> @@ -16,11 +16,15 @@
> #define __SC "sc "
> #define __INS "ins "
> #define __EXT "ext "
> +#define __ADDU "addu "
> +#define __SUBU "subu "
> #elif _MIPS_SZLONG == 64
> #define __LL "lld "
> #define __SC "scd "
> #define __INS "dins "
> #define __EXT "dext "
> +#define __ADDU "daddu "
> +#define __SUBU "dsubu "

Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)?

Maciej