Re: [PATCH] MIPS: fix local_t operation on MIPS64

kernel test robot
2021-09-04T19:10:21Z

[-- Attachment #1: Type: text/plain, Size: 7637 bytes --]

Hi Huang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.14 next-20210903]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git f1583cb1be35c23df60b1c39e3e7e6704d749d0b
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4a1c6e12f6f078dfc5351925656b237f7e5fbb50
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Huang-Pei/MIPS-fix-local_t-operation-on-MIPS64/20210904-231410
git checkout 4a1c6e12f6f078dfc5351925656b237f7e5fbb50
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash drivers/net/hamradio/ drivers/net/slip/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/hamradio/mkiss.c:35: warning: "END" redefined
35 | #define END 0300 /* indicates end of frame */
|
In file included from arch/mips/include/asm/local.h:8,
from include/linux/genhd.h:20,
from include/linux/blkdev.h:8,
from include/linux/blk-cgroup.h:23,
from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/net/sock.h:53,
from include/net/ax25.h:17,
from drivers/net/hamradio/mkiss.c:30:
arch/mips/include/asm/asm.h:68: note: this is the location of the previous definition
68 | #define END(function) \
|
--
In file included from arch/mips/include/asm/local.h:8,
from include/linux/genhd.h:20,
from include/linux/blkdev.h:8,
from include/linux/blk-cgroup.h:23,
from include/linux/writeback.h:14,
from include/linux/memcontrol.h:22,
from include/net/sock.h:53,
from include/linux/tcp.h:19,
from drivers/net/slip/slip.c:91:
>> arch/mips/include/asm/asm.h:68: warning: "END" redefined
68 | #define END(function) \
|
In file included from drivers/net/slip/slip.c:88:
drivers/net/slip/slip.h:44: note: this is the location of the previous definition
44 | #define END 0300 /* indicates end of frame */
|
drivers/net/slip/slip.c: In function 'slip_esc':
drivers/net/slip/slip.c:930:18: error: 'END' undeclared (first use in this function)
930 | *ptr++ = END;
| ^~~
drivers/net/slip/slip.c:930:18: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/slip/slip.c: In function 'slip_unesc':
drivers/net/slip/slip.c:960:14: error: 'END' undeclared (first use in this function)
960 | case END:
| ^~~
drivers/net/slip/slip.c: In function 'sl_outfill':
drivers/net/slip/slip.c:1393:75: error: 'END' undeclared (first use in this function)
1393 | unsigned char s = (sl->mode & SL_MODE_SLIP6)?0x70:END;
| ^~~

vim +/END +68 arch/mips/include/asm/asm.h

894ef530012fb507 arch/mips/include/asm/asm.h Alexander Lobakin 2021-01-10 38
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 39 /*
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 40 * LEAF - declare leaf routine
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 41 */
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 42 #define LEAF(symbol) \
894ef530012fb507 arch/mips/include/asm/asm.h Alexander Lobakin 2021-01-10 43 CFI_SECTIONS; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 44 .globl symbol; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 45 .align 2; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 46 .type symbol, @function; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 47 .ent symbol, 0; \
08889582b8aa0bbc arch/mips/include/asm/asm.h Paul Burton 2016-11-07 48 symbol: .frame sp, 0, ra; \
866b6a89c6d1876f arch/mips/include/asm/asm.h Corey Minyard 2017-08-10 49 .cfi_startproc; \
08889582b8aa0bbc arch/mips/include/asm/asm.h Paul Burton 2016-11-07 50 .insn
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 51
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 52 /*
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 53 * NESTED - declare nested routine entry point
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 54 */
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 55 #define NESTED(symbol, framesize, rpc) \
894ef530012fb507 arch/mips/include/asm/asm.h Alexander Lobakin 2021-01-10 56 CFI_SECTIONS; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 57 .globl symbol; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 58 .align 2; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 59 .type symbol, @function; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 60 .ent symbol, 0; \
08889582b8aa0bbc arch/mips/include/asm/asm.h Paul Burton 2016-11-07 61 symbol: .frame sp, framesize, rpc; \
866b6a89c6d1876f arch/mips/include/asm/asm.h Corey Minyard 2017-08-10 62 .cfi_startproc; \
08889582b8aa0bbc arch/mips/include/asm/asm.h Paul Burton 2016-11-07 63 .insn
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 64
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 65 /*
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 66 * END - mark end of function
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 67 */
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 @68 #define END(function) \
866b6a89c6d1876f arch/mips/include/asm/asm.h Corey Minyard 2017-08-10 69 .cfi_endproc; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 70 .end function; \
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 71 .size function, .-function
^1da177e4c3f4152 include/asm-mips/asm.h Linus Torvalds 2005-04-16 72

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71501 bytes --]