Re: [PATCH] MIPS: fix local_t operation on MIPS64

黄沛
2021-09-05T00:48:35Z

You mean including  asm/asm.h?

or redefine LONG_ADDU as ** "addu " ** in asm/llsc.h?

本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。

This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
Original Message
From: Maciej W. Rozycki
Sent: 2021年9月5日星期日 1:58
To: Huang Pei
Cc: Thomas Bogendoerfer; ambrosehua@gmail.com; Bibo Mao; linux-mips@vger.kernel.org; linux-arch@vger.kernel.org; linux-mm@kvack.org; Jiaxun Yang; Paul Burton; Li Xuefeng; Yang Tiezhu; Gao Juxin; Huacai Chen; Jinyang He; Steven Rostedt; Jisheng Zhang; Masami Hiramatsu
Subject: Re: [PATCH] MIPS: fix local_t operation on MIPS64

On Sat, 4 Sep 2021, Huang Pei wrote:

> diff --git a/arch/mips/include/asm/llsc.h b/arch/mips/include/asm/llsc.h
> index ec09fe5d6d6c..788e26ad7fca 100644
> --- a/arch/mips/include/asm/llsc.h
> +++ b/arch/mips/include/asm/llsc.h
> @@ -16,11 +16,15 @@
> #define __SC "sc "
> #define __INS "ins "
> #define __EXT "ext "
> +#define __ADDU "addu "
> +#define __SUBU "subu "
> #elif _MIPS_SZLONG == 64
> #define __LL "lld "
> #define __SC "scd "
> #define __INS "dins "
> #define __EXT "dext "
> +#define __ADDU "daddu "
> +#define __SUBU "dsubu "

Why invent things instead of using standard macros (LONG_ADDU/LONG_SUBU)?

Maciej