From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87730C433EF for ; Wed, 8 Sep 2021 15:20:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D4D16105A for ; Wed, 8 Sep 2021 15:20:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2D4D16105A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id B759C6B006C; Wed, 8 Sep 2021 11:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B251F6B0071; Wed, 8 Sep 2021 11:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9ED056B0072; Wed, 8 Sep 2021 11:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id 910556B006C for ; Wed, 8 Sep 2021 11:20:29 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4BD8A2775D for ; Wed, 8 Sep 2021 15:20:29 +0000 (UTC) X-FDA: 78564767778.28.D928194 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by imf27.hostedemail.com (Postfix) with ESMTP id 1D565700009B for ; Wed, 8 Sep 2021 15:20:29 +0000 (UTC) Received: by mail-ot1-f50.google.com with SMTP id c42-20020a05683034aa00b0051f4b99c40cso3473523otu.0 for ; Wed, 08 Sep 2021 08:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OZ2P9mw3evJ0P/P4xOie79/DsuG4DubNBUve1ewYQ78=; b=iHH0KMk+8RMxSZ9tk2OCzj07ySk6EOxzZLq1IU/f8ptYk4eWvbW5lL1rco4I+WLD6Z llGmb0VyUwqJRCQZq6y1AxvYW6i/RqNx96pDOYCHXCro4R6GssOj5m5ELxQTLqfbnul7 2BhPFjP1yYykUEojCKqtPk2e4VEzwuxytb//SuMxCCfiOdIwkivLdmCJ4PeIra02Woe3 Z6Hw8YjSgVF371GmFia0IMMAzseDloXzERhqveZSS6AvVH+Jqkn+taLdzFJ5aOVu1ADh p1/AUYyXCa6MiVPG6UhcyOpA/5rgeoTlcio4iyKppypq0ji/4ed9l3mWpv8aDw5SaUXz x94w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=OZ2P9mw3evJ0P/P4xOie79/DsuG4DubNBUve1ewYQ78=; b=FDic63vqt1GWAJSTxBZTfy+e+bkCv9jd+C1DI5C4CgLuYaGAQGXTq13jXIRMZzrsVb 1bbnQlTEDs77ZTu/gzyOu81kgdL1xGxkpy1tirk7RycYkOzlk4tSs6ZKDWFbk0pjsbhH PA8k/ARgfp1glTjeIPTf2yEmhtfnLWVWO9VkvmMmnmne635KldkII5rs/l+iG10F3HQX rnnI30gbQ21eMie6jY6vM0sQ9SpfJ7LT1MbylGR3CYxLMHSoQGuNpFuIZc8X52SCVD8G LRoIqhpA2x7RPbF3Nl+0Lcu+ZvK59A/LGSSiZ4y55Sa7k4dmfyFoEZ8Dw21PxiDOjzyY ImhA== X-Gm-Message-State: AOAM530LR3Gurgli7K99Q65vfYoUzW4QVDsYbm7O18UkaOAysIzEm8mW c/4tx2l4CPbnV0FpfZXHpUs= X-Google-Smtp-Source: ABdhPJykU+BnKFSX2H2eEnY5PXaRYHIodrFLISD1QZbpXa9HVxp9M4KhIjMn/qQWqR66X/w4qbACPA== X-Received: by 2002:a9d:4605:: with SMTP id y5mr3465775ote.171.1631114428478; Wed, 08 Sep 2021 08:20:28 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id l3sm489631otd.79.2021.09.08.08.20.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 08:20:27 -0700 (PDT) Date: Wed, 8 Sep 2021 08:20:26 -0700 From: Guenter Roeck To: Mike Rapoport Cc: Andrew Morton , Greentime Hu , kernel test robot , Nick Hu , Vincent Chen , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport , kernel test robot Subject: Re: [PATCH] nds32/setup: remove unused memblock_region variable in setup_memory() Message-ID: <20210908152026.GA389642@roeck-us.net> References: <20210712125218.28951-1-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210712125218.28951-1-rppt@kernel.org> Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=iHH0KMk+; spf=pass (imf27.hostedemail.com: domain of groeck7@gmail.com designates 209.85.210.50 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1D565700009B X-Stat-Signature: tja5chbtmn7xkkrtc9neh5iwkxxg7yp6 X-HE-Tag: 1631114429-915429 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 12, 2021 at 03:52:18PM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > kernel test robot reports unused variable warning: > > cppcheck possible warnings: (new ones prefixed by >>, may not real > problems) > > >> arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region > >> [unusedVariable] > struct memblock_region *region; > ^ > > Remove the unused variable. > > Reported-by: kernel test robot > Signed-off-by: Mike Rapoport Reviewed-by: Guenter Roeck Tested-by: Guenter Roeck This is now fatal. arch/nds32/kernel/setup.c: In function 'setup_memory': arch/nds32/kernel/setup.c:247:26: error: unused variable 'region' Anyone care to apply it ? Guenter > --- > arch/nds32/kernel/setup.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/nds32/kernel/setup.c b/arch/nds32/kernel/setup.c > index 41725eaf8bac..b3d34d646652 100644 > --- a/arch/nds32/kernel/setup.c > +++ b/arch/nds32/kernel/setup.c > @@ -244,7 +244,6 @@ static void __init setup_memory(void) > unsigned long ram_start_pfn; > unsigned long free_ram_start_pfn; > phys_addr_t memory_start, memory_end; > - struct memblock_region *region; > > memory_end = memory_start = 0; > > > base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3 > -- > 2.28.0 >