From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3905C433FE for ; Tue, 14 Sep 2021 15:08:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A55160FD7 for ; Tue, 14 Sep 2021 15:08:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A55160FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D8418900002; Tue, 14 Sep 2021 11:08:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D34696B0071; Tue, 14 Sep 2021 11:08:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C22AF900002; Tue, 14 Sep 2021 11:08:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0061.hostedemail.com [216.40.44.61]) by kanga.kvack.org (Postfix) with ESMTP id B34046B006C for ; Tue, 14 Sep 2021 11:08:44 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 550BA180CD5F5 for ; Tue, 14 Sep 2021 15:08:44 +0000 (UTC) X-FDA: 78586510968.29.0F59FC5 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id C7322300009B for ; Tue, 14 Sep 2021 15:08:43 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D945101E; Tue, 14 Sep 2021 08:08:42 -0700 (PDT) Received: from a077416.arm.com (unknown [10.163.44.128]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 73B6D3F5A1; Tue, 14 Sep 2021 08:08:40 -0700 (PDT) From: Amit Daniel Kachhap To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Vincenzo Frascino , Amit Daniel Kachhap , Andrew Morton Subject: [PATCH] mm/memory: Avoid unnecessary kernel/user pointer conversion Date: Tue, 14 Sep 2021 20:38:20 +0530 Message-Id: <20210914150820.19326-1-amit.kachhap@arm.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C7322300009B Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of amit.kachhap@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=amit.kachhap@arm.com X-Stat-Signature: 4iji91q9ir6kcxzcz3nnkxbguphdn6s8 X-HE-Tag: 1631632123-631636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Annotating a pointer from __user to kernel and then back again might confuse sparse. In copy_huge_page_from_user() it can be avoided by removing the intermediate variable since it is never used. Cc: Andrew Morton Signed-off-by: Amit Daniel Kachhap --- mm/memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/mm/memory.c b/mm/memory.c index 25fc46e87214..90970d19b7dd 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5411,7 +5411,6 @@ long copy_huge_page_from_user(struct page *dst_page, unsigned int pages_per_huge_page, bool allow_pagefault) { - void *src = (void *)usr_src; void *page_kaddr; unsigned long i, rc = 0; unsigned long ret_val = pages_per_huge_page * PAGE_SIZE; @@ -5424,8 +5423,7 @@ long copy_huge_page_from_user(struct page *dst_page, else page_kaddr = kmap_atomic(subpage); rc = copy_from_user(page_kaddr, - (const void __user *)(src + i * PAGE_SIZE), - PAGE_SIZE); + usr_src + i * PAGE_SIZE, PAGE_SIZE); if (allow_pagefault) kunmap(subpage); else -- 2.17.1