From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643F8C433F5 for ; Wed, 15 Sep 2021 10:40:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D7F1161242 for ; Wed, 15 Sep 2021 10:40:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D7F1161242 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E59466B0071; Wed, 15 Sep 2021 06:40:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E08DB6B0072; Wed, 15 Sep 2021 06:40:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF759900002; Wed, 15 Sep 2021 06:40:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0235.hostedemail.com [216.40.44.235]) by kanga.kvack.org (Postfix) with ESMTP id C16906B0071 for ; Wed, 15 Sep 2021 06:40:28 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6DD0B39B8C for ; Wed, 15 Sep 2021 10:40:28 +0000 (UTC) X-FDA: 78589463736.08.5F8D7B2 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf23.hostedemail.com (Postfix) with ESMTP id 2D61D90000AC for ; Wed, 15 Sep 2021 10:40:28 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id i7so4971571lfr.13 for ; Wed, 15 Sep 2021 03:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=a/GCtVpvhwVIk1SywYX5YYFVF3L25bb3Bu0j55SRB24=; b=F4X13sv85qlRDDGNT934A1gwgVq152F28CjwxEmHWp5QoNhFlLfGtaqRmrbtgwFI4g RcQmXbvtmgFuhw3kwUj511XOgpddIwKvyro1pjK6LdK1Wvt1CQqiwtE95uaewMmG4gjT CtYQUT7gTVilccItlvMr+/R4kkVzMMX62w7b13NNca2Wm5wx83Md4QNlU1CUXkPdI8Ha GUmk1lbIcUs/H6JEkz7Z5B1XrmqfJlMcxF8D+LqP0aTsafCY2WOmKZNXJ6/PpeJoRiQw kxc/mSdxkYFkx652FozpJZgkSFN2SqCP5zKQip4upN84qh6+u667sOBV8IIpRCvvUkfD DrKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a/GCtVpvhwVIk1SywYX5YYFVF3L25bb3Bu0j55SRB24=; b=2CC9mEXcISiUN7EtBxROlPlg1DABmLVi8ZmEQXmuoY3QlbT7akVxxgtuH/4HXE0oC9 HUQ6IN988kdyVhX2DLlYthDJvJpWDnhJnv2AF7fPOUnFxa4GQxIH8MpRZMlejaHIhQFa Bw2nRxEAETPfKKZwNwzyx2tcJUBsAL1axfChqkOt97ivd/iBxRRtw893t1GzuAMgtlwR cQb02hHXzG9yHlwaTbZ7HKCDE89LcBuQaLDC41mWph25/LNL7RXX1vw5KfN+6hHiTdQt gV0EhNFJvAsLMuXkMvtOpwsaEfzj0m3jIE+/IXHOBs2hGxeHdtH4FPuGC3+R4vslJOpr 62uw== X-Gm-Message-State: AOAM533XPpwwPxy6zv3IizYO82yVCeLE9aQa3nHs2Kvv6GknMVQKbM07 0jbdA66i/L/kmMTrPVjaCMEDdw== X-Google-Smtp-Source: ABdhPJztrGap47YE/7uFZQfvJHSMuv017KdT8GnercdtDSz207RC8iHDJBIFlGXPIToLigf7pRWJTw== X-Received: by 2002:ac2:5d71:: with SMTP id h17mr16352495lft.670.1631702426202; Wed, 15 Sep 2021 03:40:26 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id q7sm1673012ljg.137.2021.09.15.03.40.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Sep 2021 03:40:25 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id C2AFB102F4D; Wed, 15 Sep 2021 13:40:28 +0300 (+03) Date: Wed, 15 Sep 2021 13:40:28 +0300 From: "Kirill A. Shutemov" To: Amit Daniel Kachhap Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vincenzo Frascino , Andrew Morton Subject: Re: [PATCH] mm/memory: Avoid unnecessary kernel/user pointer conversion Message-ID: <20210915104028.77qwldwnwpcbjds6@box.shutemov.name> References: <20210914150820.19326-1-amit.kachhap@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914150820.19326-1-amit.kachhap@arm.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 2D61D90000AC X-Stat-Signature: q1zfo5yx5dexyxp3a1x36n8qd6ngdhoi Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=shutemov-name.20150623.gappssmtp.com header.s=20150623 header.b=F4X13sv8; spf=none (imf23.hostedemail.com: domain of kirill@shutemov.name has no SPF policy when checking 209.85.167.42) smtp.mailfrom=kirill@shutemov.name; dmarc=none X-HE-Tag: 1631702428-211067 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 14, 2021 at 08:38:20PM +0530, Amit Daniel Kachhap wrote: > Annotating a pointer from __user to kernel and then back again might > confuse sparse. In copy_huge_page_from_user() it can be avoided by > removing the intermediate variable since it is never used. > > Cc: Andrew Morton > Signed-off-by: Amit Daniel Kachhap Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov