From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: zhangyiru <zhangyiru3@huawei.com>,
linux-mm@kvack.org, wuxu.wu@huawei.com, liusirui@huawei.com,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH Vx RESEND] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB
Date: Wed, 15 Sep 2021 16:55:52 -0700 [thread overview]
Message-ID: <20210915165552.d10ba7f80f21167fd42a258c@linux-foundation.org> (raw)
In-Reply-To: <a36918f4-6af7-79cd-7aad-df6c1db32ab4@oracle.com>
On Tue, 7 Sep 2021 13:52:04 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> On 9/4/21 12:54 AM, zhangyiru wrote:
> > remove mlock ulimit for SHM_HUGETLB
> > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to
> > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012,
> > but it is not deleted yet
>
> A better commit to mention would be 2584e517320b ("mm: reintroduce and
> deprecate rlimit based access for SHM_HUGETLB"). IIUC, 21a3c273f88c just
> modified the log message.
I made that change to the changelog.
> There is nothing wrong with the code. Adding Andrew and Michal on Cc:
> as I have little or no experience with removing deprecated
> features/code. This certainly has been marked deprecated for a long
> time (since 2.6.31).
I'd have thought that emitting a nasty message for a decade would suffice.
> However, I still see that message in log files on
> occasion.
However I appear to be wrong :(
A quick web search indicates that people were reporting this in 2020,
at least. So I don't think we can remove it.
otoh, one report was against RHEL3 which went end-of-life in 2015. So
perhaps some more research on this will end up making the justifiable.
I dunno, I'm just waffling. Maybe just merge it and if someone
complains, they can't say they weren't warned!
prev parent reply other threads:[~2021-09-15 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-04 7:54 [PATCH Vx RESEND] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB zhangyiru
2021-09-07 20:52 ` Mike Kravetz
2021-09-15 23:55 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915165552.d10ba7f80f21167fd42a258c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=liusirui@huawei.com \
--cc=mhocko@suse.com \
--cc=mike.kravetz@oracle.com \
--cc=wuxu.wu@huawei.com \
--cc=zhangyiru3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).