From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E099C433EF for ; Wed, 15 Sep 2021 23:55:57 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E60E261131 for ; Wed, 15 Sep 2021 23:55:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E60E261131 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 81A606B0071; Wed, 15 Sep 2021 19:55:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C962900002; Wed, 15 Sep 2021 19:55:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B7926B0073; Wed, 15 Sep 2021 19:55:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 5C3C26B0071 for ; Wed, 15 Sep 2021 19:55:56 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0582D22036 for ; Wed, 15 Sep 2021 23:55:56 +0000 (UTC) X-FDA: 78591468312.26.8B3C6EE Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id AD3516001981 for ; Wed, 15 Sep 2021 23:55:55 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 2009860D07; Wed, 15 Sep 2021 23:55:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1631750153; bh=uhsKJlSmnlSLmd714VqRlQauEfeqkGTQQNurqeBGPOM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PxOLRBpcfk7lq433xCdl2Js1ewfIlt2jblFPkaVwTwbK18C7C1llOQztj79CH8vHN HHOiN97n1Kg3ZoENM0Feu7d5NyRgjKu1LZG7gw12Vy5h7mK+uJ+jlrMypwt1wXolF7 r2VO5CDyqnzQaFLW02z4KrLAfswl+vN446xKa1GQ= Date: Wed, 15 Sep 2021 16:55:52 -0700 From: Andrew Morton To: Mike Kravetz Cc: zhangyiru , linux-mm@kvack.org, wuxu.wu@huawei.com, liusirui@huawei.com, Michal Hocko Subject: Re: [PATCH Vx RESEND] mm,hugetlb: remove mlock ulimit for SHM_HUGETLB Message-Id: <20210915165552.d10ba7f80f21167fd42a258c@linux-foundation.org> In-Reply-To: References: <20210904075458.51012-1-zhangyiru3@huawei.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AD3516001981 X-Stat-Signature: azt8zko1yy7qnn4qt1hqm7fp59754gbx Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=PxOLRBpc; spf=pass (imf14.hostedemail.com: domain of akpm@linux-foundation.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none X-HE-Tag: 1631750155-895766 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 7 Sep 2021 13:52:04 -0700 Mike Kravetz wrote: > On 9/4/21 12:54 AM, zhangyiru wrote: > > remove mlock ulimit for SHM_HUGETLB > > commit 21a3c273f88c9cbbaf7e ("mm, hugetlb: add thread name and pid to > > SHM_HUGETLB mlock rlimit warning") marked this as deprecated in 2012, > > but it is not deleted yet > > A better commit to mention would be 2584e517320b ("mm: reintroduce and > deprecate rlimit based access for SHM_HUGETLB"). IIUC, 21a3c273f88c just > modified the log message. I made that change to the changelog. > There is nothing wrong with the code. Adding Andrew and Michal on Cc: > as I have little or no experience with removing deprecated > features/code. This certainly has been marked deprecated for a long > time (since 2.6.31). I'd have thought that emitting a nasty message for a decade would suffice. > However, I still see that message in log files on > occasion. However I appear to be wrong :( A quick web search indicates that people were reporting this in 2020, at least. So I don't think we can remove it. otoh, one report was against RHEL3 which went end-of-life in 2015. So perhaps some more research on this will end up making the justifiable. I dunno, I'm just waffling. Maybe just merge it and if someone complains, they can't say they weren't warned!