From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Linux-MM <linux-mm@kvack.org>,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH v3 3/3] bootconfig: Free xbc_data in xbc_destroy_all()
Date: Wed, 15 Sep 2021 20:17:09 -0400 [thread overview]
Message-ID: <20210915201709.1406426a@oasis.local.home> (raw)
In-Reply-To: <20210916090503.c9d8209e8c88e9c4c7d3072c@kernel.org>
On Thu, 16 Sep 2021 09:05:03 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Ah, it is my policy that the error or information message is shown
> by caller (since caller can also ignore that, e.g. passing the
> testing data), not from the library code.
> I learned that from perf-probe and ftrace, sometimes the library
> code reused in unexpected way. So I decided to decouple the
> generating error message and showing it.
OK, then we can just pass the number of nodes allocated via a pointer
to an integer.
Thanks!
-- Steve
next prev parent reply other threads:[~2021-09-16 0:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 13:19 [PATCH v3 0/3] bootconfig: Fixes to bootconfig memory management Masami Hiramatsu
2021-09-15 13:19 ` [PATCH v3 1/3] bootconfig: init: Fix memblock leak in xbc_make_cmdline() Masami Hiramatsu
2021-09-15 13:19 ` [PATCH v3 2/3] bootconfig: init: Fix memblock leak in setup_boot_config() Masami Hiramatsu
2021-09-15 13:19 ` [PATCH v3 3/3] bootconfig: Free xbc_data in xbc_destroy_all() Masami Hiramatsu
2021-09-15 14:23 ` Steven Rostedt
2021-09-16 0:05 ` Masami Hiramatsu
2021-09-16 0:17 ` Steven Rostedt [this message]
2021-09-15 16:47 ` [PATCH v3 0/3] bootconfig: Fixes to bootconfig memory management Linus Torvalds
2021-09-15 16:51 ` Linus Torvalds
2021-09-16 0:07 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915201709.1406426a@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=rppt@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).