From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB74EC433F5 for ; Tue, 21 Sep 2021 11:03:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 507216115A for ; Tue, 21 Sep 2021 11:03:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 507216115A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=techsingularity.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DF970940008; Tue, 21 Sep 2021 07:03:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA9D6900002; Tue, 21 Sep 2021 07:03:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9854940008; Tue, 21 Sep 2021 07:03:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0067.hostedemail.com [216.40.44.67]) by kanga.kvack.org (Postfix) with ESMTP id BB7E4900002 for ; Tue, 21 Sep 2021 07:03:26 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 7073F18077B24 for ; Tue, 21 Sep 2021 11:03:26 +0000 (UTC) X-FDA: 78611294412.36.7FB2036 Received: from outbound-smtp34.blacknight.com (outbound-smtp34.blacknight.com [46.22.139.253]) by imf28.hostedemail.com (Postfix) with ESMTP id E88F8900009E for ; Tue, 21 Sep 2021 11:03:25 +0000 (UTC) Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp34.blacknight.com (Postfix) with ESMTPS id B33FE2606 for ; Tue, 21 Sep 2021 12:03:24 +0100 (IST) Received: (qmail 2386 invoked from network); 21 Sep 2021 11:03:24 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.17.29]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Sep 2021 11:03:24 -0000 Date: Tue, 21 Sep 2021 12:03:23 +0100 From: Mel Gorman To: NeilBrown Cc: Linux-MM , Theodore Ts'o , Andreas Dilger , "Darrick J . Wong" , Matthew Wilcox , Michal Hocko , Dave Chinner , Rik van Riel , Vlastimil Babka , Johannes Weiner , Jonathan Corbet , Linux-fsdevel , LKML Subject: Re: [PATCH 2/5] mm/vmscan: Throttle reclaim and compaction when too may pages are isolated Message-ID: <20210921110323.GP3959@techsingularity.net> References: <20210920085436.20939-1-mgorman@techsingularity.net> <20210920085436.20939-3-mgorman@techsingularity.net> <163218047640.3992.16597395100064789255@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <163218047640.3992.16597395100064789255@noble.neil.brown.name> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.253 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net X-Stat-Signature: 7mp1ryybjkuadh3w19eohzmc7bt3pzjt X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E88F8900009E X-HE-Tag: 1632222205-474830 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 09:27:56AM +1000, NeilBrown wrote: > On Mon, 20 Sep 2021, Mel Gorman wrote: > > @@ -2291,8 +2302,7 @@ shrink_inactive_list(unsigned long nr_to_scan, struct lruvec *lruvec, > > return 0; > > > > /* wait a bit for the reclaimer. */ > > - msleep(100); > > - stalled = true; > > + reclaim_throttle(pgdat, VMSCAN_THROTTLE_ISOLATED, HZ/10); > > Why drop the assignment to "stalled"? > Doing that changes the character of the loop - and makes the 'stalled' > variable always 'false'. > This was a thought that was never completed. The intent was that if there are too many pages isolated that it should not return prematurely and do busy work elsewhere. It potentially means an allocation request moves to lower zones or remote nodes prematurely but I never did the full removal. Even if I had, on reflection, that type of behavioural change does not belong in this series. I've restored the "stalled = true". -- Mel Gorman SUSE Labs