From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6385C433EF for ; Tue, 21 Sep 2021 12:33:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 584DC60F0F for ; Tue, 21 Sep 2021 12:33:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 584DC60F0F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id D91E56B0071; Tue, 21 Sep 2021 08:33:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D41E16B0074; Tue, 21 Sep 2021 08:33:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C30A9900002; Tue, 21 Sep 2021 08:33:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id B59B46B0071 for ; Tue, 21 Sep 2021 08:33:04 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 6A636181CC1C0 for ; Tue, 21 Sep 2021 12:33:04 +0000 (UTC) X-FDA: 78611520288.01.E17EB53 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 0669C1901 for ; Tue, 21 Sep 2021 12:33:03 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B644D22113; Tue, 21 Sep 2021 12:33:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1632227582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tHYjB+PylponO9o3SOyjJk7Ga4SEkTKyJ/ThM4qiWO8=; b=XnKlOhrb1DP7in/DcBC+5HImoKYcpvy/Rlz9IMaeQ+IWjzo7fXUdJZn84bBc2adMHD5EkZ 4H3OCK+CEjxyxxLK28ylUncFXgIUS1t/qjr4Cnmc8jOBJjYDWwBeEjwHNyMqLFMo+Yk02L Nq4UWodnw6FRfn1W4EEsl6t6LmkzjQU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1632227582; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tHYjB+PylponO9o3SOyjJk7Ga4SEkTKyJ/ThM4qiWO8=; b=wmhPEEBO/+QmAG2MzcQc1bcfrMpKA4YSM9IWxWxJoDhXuOMIOWt9OEqltpqdVQhW3x4kYu l7JQ/fDY8reHtbAw== Received: from suse.de (unknown [10.163.32.246]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 203F8A3BA0; Tue, 21 Sep 2021 12:33:01 +0000 (UTC) Date: Tue, 21 Sep 2021 13:32:58 +0100 From: Mel Gorman To: Geert Uytterhoeven Cc: Matt Fleming , Peter Zijlstra , Ingo Molnar , Juri Lelli , Vincent Guittot , Andrew Morton , Vlastimil Babka , Yoshinori Sato , Rich Felker , Gon Solo , linux-mm@kvack.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: Move node_reclaim_distance to fix NUMA without SMP Message-ID: <20210921123258.GE3891@suse.de> References: <6432666a648dde85635341e6c918cee97c97d264.1631781495.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <6432666a648dde85635341e6c918cee97c97d264.1631781495.git.geert+renesas@glider.be> User-Agent: Mutt/1.10.1 (2018-07-13) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XnKlOhrb; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=wmhPEEBO; spf=pass (imf22.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=mgorman@suse.de; dmarc=pass (policy=none) header.from=suse.de X-Stat-Signature: 7hhyntxuqdm8ken6sphgzkeczoeki51b X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0669C1901 X-HE-Tag: 1632227583-388381 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 10:42:42AM +0200, Geert Uytterhoeven wrote: > If CONFIG_NUMA=y, but CONFIG_SMP=n (e.g. sh/migor_defconfig): > > sh4-linux-gnu-ld: mm/page_alloc.o: in function `get_page_from_freelist': > page_alloc.c:(.text+0x2c24): undefined reference to `node_reclaim_distance' > > Fix this by moving the declaration of node_reclaim_distance from an > SMP-only to a generic file. > > Fixes: a55c7454a8c887b2 ("sched/topology: Improve load balancing on AMD EPYC systems") > Suggested-by: Matt Fleming > Signed-off-by: Geert Uytterhoeven Acked-by: Mel Gorman -- Mel Gorman SUSE Labs