From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7D5DC433EF for ; Tue, 21 Sep 2021 15:38:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10F3660E08 for ; Tue, 21 Sep 2021 15:38:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 10F3660E08 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id AA00694000F; Tue, 21 Sep 2021 11:38:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4E63940007; Tue, 21 Sep 2021 11:38:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9656D94000F; Tue, 21 Sep 2021 11:38:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id 886F5940007 for ; Tue, 21 Sep 2021 11:38:09 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 53D5F2D4A3 for ; Tue, 21 Sep 2021 15:38:09 +0000 (UTC) X-FDA: 78611986698.12.EBE68BE Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf12.hostedemail.com (Postfix) with ESMTP id AAFD310000A5 for ; Tue, 21 Sep 2021 15:38:08 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 620AF67373; Tue, 21 Sep 2021 17:38:05 +0200 (CEST) Date: Tue, 21 Sep 2021 17:38:05 +0200 From: Christoph Hellwig To: Mike Rapoport Cc: Christoph Hellwig , Catalin Marinas , David Hildenbrand , Robin Murphy , Alex Bee , Will Deacon , Andrew Morton , Anshuman Khandual , Linux Kernel Mailing List , linux-mm@kvack.org, Linux ARM Subject: Re: [BUG 5.14] arm64/mm: dma memory mapping fails (in some cases) Message-ID: <20210921153805.GA29952@lst.de> References: <0908ce39-7e30-91fa-68ef-11620f9596ae@arm.com> <60a11eba-2910-3b5f-ef96-97d4556c1596@redhat.com> <20210825102044.GA3420@arm.com> <20210918051843.GA16104@lst.de> <20210921082007.GA29121@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=none; spf=none (imf12.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AAFD310000A5 X-Stat-Signature: teh8yxi4pinqhgpmc5k7rkundjf8io47 X-HE-Tag: 1632238688-377691 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 21, 2021 at 12:34:10PM +0300, Mike Rapoport wrote: > > It doesn't create any new mappings. The only real issue is that it > > does the wrong thing for RAM in a way that might not be noticed on > > simple (x86/PC) platforms. > > But if the mapping request was rejected by devm_ioremap_resource() because > of an attempt to map RAM, why we would get to dma_map_resource() at all? dma_map_resource takes a phys_addr_t that could come from anywhere.