Re: [PATCH v3 9/9] mm: Remove swap BIO paths and only use DIO paths

David Sterba
2021-09-27T20:03:27Z

On Sat, Sep 25, 2021 at 04:36:42PM +0100, David Howells wrote:
> Matthew Wilcox <willy@infradead.org> wrote:
>
> > On Fri, Sep 24, 2021 at 06:19:23PM +0100, David Howells wrote:
> > > Delete the BIO-generating swap read/write paths and always use ->swap_rw().
> > > This puts the mapping layer in the filesystem.
> >
> > Is SWP_FS_OPS now unused after this patch?
>
> Ummm. Interesting question - it's only used in swap_set_page_dirty():
>
> int swap_set_page_dirty(struct page *page)
> {
> struct swap_info_struct *sis = page_swap_info(page);
>
> if (data_race(sis->flags & SWP_FS_OPS)) {
> struct address_space *mapping = sis->swap_file->f_mapping;
>
> VM_BUG_ON_PAGE(!PageSwapCache(page), page);
> return mapping->a_ops->set_page_dirty(page);
> } else {
> return __set_page_dirty_no_writeback(page);
> }
> }
>
>
> > Also, do we still need ->swap_activate and ->swap_deactivate?
>
> f2fs does quite a lot of work in its ->swap_activate(), as does btrfs. I'm
> not sure how necessary it is.

Yes we still need it for btrfs. Besides checking the conditions similar
to what iomap_swapfile_activate does on the file itself, we need to
exclude other operations potentially changing the mapping on the level
of block groups. This is namely relocation, used to implement several
other things like resize or balance. There's an exclusion at the
beginning of btrfs_swap_activate. Right now I don't see how we could
make sure that the swapfile requirements would be satisfied without it.