From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41AFC433EF for ; Tue, 28 Sep 2021 19:43:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6859E61139 for ; Tue, 28 Sep 2021 19:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6859E61139 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id E11736B0071; Tue, 28 Sep 2021 15:43:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9A396B0072; Tue, 28 Sep 2021 15:43:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C613C900002; Tue, 28 Sep 2021 15:43:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id B367A6B0071 for ; Tue, 28 Sep 2021 15:43:28 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6D60932099 for ; Tue, 28 Sep 2021 19:43:28 +0000 (UTC) X-FDA: 78638006496.21.9D1A44F Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by imf06.hostedemail.com (Postfix) with ESMTP id 32118801A89F for ; Tue, 28 Sep 2021 19:43:28 +0000 (UTC) Received: by mail-io1-f46.google.com with SMTP id e144so91940iof.3 for ; Tue, 28 Sep 2021 12:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rjLk0h/mLxEL3Q6/W9L7mqQkVvY6tzCz4tgaLSgLx3s=; b=hhjthCUJo5WhNKDnLCpo+MVqy6n87T1pJjZguVrbGVB7rs1TEqj8vSzkH1OSVJ4aHY Y4CBMG1r9Rmy0NZyrlH5NzTg+Y8qxZoKLG0AvCFUREnWT/psrYWEBqSqvzXvNv5yTDIr on4+mWLbQe9rhU1sJ0QNKudA3/36oLT7Zw6sZzQBD1xnoS8UNH2nV0XaX4yDc24jjF2F 7QkD0f5nx2AT5EawBHny0YCDHI8greowW1MBzYmGKp/2RhkC/7+QDf784bbYh0ttqPja SIBG9NG6TFsrj3x8A3HpfCET+Sjd2Z1Hfpwi/GMS9Z23rUtCt6WAlr+9cdU9alzqPn1Q 1OpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rjLk0h/mLxEL3Q6/W9L7mqQkVvY6tzCz4tgaLSgLx3s=; b=4KGdb0StcdzUtqrrrAuO4NUi2COBcNvkD+v363tr0Yzz3mztZSBcw1Op4RutYX77jl 7UC3knZNe22gdQ9NqQGgV0H0AVUPLGCxqlz5mdjAt2GdUdr9iJyBkjD1p8OwXMxuT/j/ XAsSm7cYROg/eIAOPM+VKPIAKXt7oBur0wAjDrwz7ChXJxOiH+fsUQHi9eENgRzx+3nP sS+bq8j+v62GL2peB7MgAPUY8ZPc9nSnXP1jtp15zfmKiaaD0qwYEDpc3oRQ4zXu4MGm jRAM+gt6ilZ0Gmmk5qWAhuabKkavbtKMEXU2aXN54sBG/hmvBTLAP7yLZuKTd3OvvVgY DWSw== X-Gm-Message-State: AOAM5338Yn8cAjofGaWu1GBfWkSHi/LBOR9O4bSGcHtPOuwGyKFv6acR yOASu/USw8RqAI+WphOLkRzk2A== X-Google-Smtp-Source: ABdhPJxTc9Esg662iHYF19mOveiU9FtR9gwP3ZO8mFkHuFuDP2iiQ1yQeLzvOs2cq2YVQPchFaVZug== X-Received: by 2002:a02:b91a:: with SMTP id v26mr6047050jan.78.1632858207605; Tue, 28 Sep 2021 12:43:27 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id a11sm12090741ilm.36.2021.09.28.12.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Sep 2021 12:43:27 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mVJ0f-007GWk-Q4; Tue, 28 Sep 2021 16:43:25 -0300 Date: Tue, 28 Sep 2021 16:43:25 -0300 From: Jason Gunthorpe To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , John Hubbard , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy , Martin Oliveira , Chaitanya Kulkarni Subject: Re: [PATCH v3 12/20] RDMA/rw: use dma_map_sgtable() Message-ID: <20210928194325.GS3544071@ziepe.ca> References: <20210916234100.122368-1-logang@deltatee.com> <20210916234100.122368-13-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916234100.122368-13-logang@deltatee.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 32118801A89F X-Stat-Signature: jd4uz5dfdx5izekpftrthtyydktd5x8w Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=hhjthCUJ; spf=pass (imf06.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.166.46 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none X-HE-Tag: 1632858208-613487 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 16, 2021 at 05:40:52PM -0600, Logan Gunthorpe wrote: > dma_map_sg() now supports the use of P2PDMA pages so pci_p2pdma_map_sg() > is no longer necessary and may be dropped. > > Switch to the dma_map_sgtable() interface which will allow for better > error reporting if the P2PDMA pages are unsupported. > > The change to sgtable also appears to fix a couple subtle error path > bugs: > > - In rdma_rw_ctx_init(), dma_unmap would be called with an sg > that could have been incremented from the original call, as > well as an nents that was not the original number of nents > called when mapped. > - Similarly in rdma_rw_ctx_signature_init, both sg and prot_sg > were unmapped with the incorrect number of nents. Those bugs should definately get fixed.. I might extract the sgtable conversion into a stand alone patch to do it. But as it is, this looks fine Reviewed-by: Jason Gunthorpe Jason