From: Steven Rostedt <rostedt@goodmis.org>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz,
axelrasmussen@google.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk
Date: Sun, 10 Oct 2021 17:45:55 -0400 [thread overview]
Message-ID: <20211010174555.6a623b29@rorschach.local.home> (raw)
In-Reply-To: <20211009071105.69544-1-ligang.bdlg@bytedance.com>
On Sat, 9 Oct 2021 15:11:05 +0800
Gang Li <ligang.bdlg@bytedance.com> wrote:
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
Yes, thank you!
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> include/trace/events/mmap_lock.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s success=%s\n",
> + "mm=%p memcg_path=%s write=%s success=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
next prev parent reply other threads:[~2021-10-10 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 7:11 [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
2021-10-10 21:45 ` Steven Rostedt [this message]
2021-10-11 7:54 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211010174555.6a623b29@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).