From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5702C433F5 for ; Sun, 10 Oct 2021 21:46:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3230460F46 for ; Sun, 10 Oct 2021 21:46:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3230460F46 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 7C410900002; Sun, 10 Oct 2021 17:45:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7750A6B0072; Sun, 10 Oct 2021 17:45:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6629A900002; Sun, 10 Oct 2021 17:45:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0149.hostedemail.com [216.40.44.149]) by kanga.kvack.org (Postfix) with ESMTP id 57B226B006C for ; Sun, 10 Oct 2021 17:45:59 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 09566181AEF15 for ; Sun, 10 Oct 2021 21:45:59 +0000 (UTC) X-FDA: 78681860838.22.0DD3B56 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf07.hostedemail.com (Postfix) with ESMTP id A37FA1002AF4 for ; Sun, 10 Oct 2021 21:45:58 +0000 (UTC) Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B8A860EB4; Sun, 10 Oct 2021 21:45:57 +0000 (UTC) Date: Sun, 10 Oct 2021 17:45:55 -0400 From: Steven Rostedt To: Gang Li Cc: mingo@redhat.com, akpm@linux-foundation.org, vbabka@suse.cz, axelrasmussen@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 1/2] mm: mmap_lock: remove redundant "\n" in TP_printk Message-ID: <20211010174555.6a623b29@rorschach.local.home> In-Reply-To: <20211009071105.69544-1-ligang.bdlg@bytedance.com> References: <20211009071105.69544-1-ligang.bdlg@bytedance.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Authentication-Results: imf07.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf07.hostedemail.com: domain of "SRS0=8qKb=O6=goodmis.org=rostedt@kernel.org" designates 198.145.29.99 as permitted sender) smtp.mailfrom="SRS0=8qKb=O6=goodmis.org=rostedt@kernel.org" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A37FA1002AF4 X-Stat-Signature: btwk1rs5qmha6qoarwwr739sdqofyk4h X-HE-Tag: 1633902358-315918 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 9 Oct 2021 15:11:05 +0800 Gang Li wrote: > Ftrace core will add "\n" automatically on print. "\n" in TP_printk > will create blank line, so remove it. > Yes, thank you! Reviewed-by: Steven Rostedt (VMware) -- Steve > Signed-off-by: Gang Li > --- > include/trace/events/mmap_lock.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h > index 0abff67b96f0..5f980c92e3e9 100644 > --- a/include/trace/events/mmap_lock.h > +++ b/include/trace/events/mmap_lock.h > @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false" > @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s success=%s\n", > + "mm=%p memcg_path=%s write=%s success=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false", > @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released, > ), > > TP_printk( > - "mm=%p memcg_path=%s write=%s\n", > + "mm=%p memcg_path=%s write=%s", > __entry->mm, > __get_str(memcg_path), > __entry->write ? "true" : "false"