From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D455C433EF for ; Mon, 18 Oct 2021 07:35:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CA5B3610A3 for ; Mon, 18 Oct 2021 07:35:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA5B3610A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 59C096B006C; Mon, 18 Oct 2021 03:35:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54A726B0071; Mon, 18 Oct 2021 03:35:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4399B900002; Mon, 18 Oct 2021 03:35:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 34D326B006C for ; Mon, 18 Oct 2021 03:35:58 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D9ED930C7C for ; Mon, 18 Oct 2021 07:35:57 +0000 (UTC) X-FDA: 78708749154.08.830EDB2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf10.hostedemail.com (Postfix) with ESMTP id 524DB6001990 for ; Mon, 18 Oct 2021 07:35:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 164FF219B5; Mon, 18 Oct 2021 07:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1634542556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g8AdCq04FqHxZQpu0wW2BfZ1BcVn5cU9ZAer2RqlbyU=; b=u2TIUP/Mdjy3STk91DJsStl8q1CoRWwSY5eeKZK0tecdBKiQyPyma/s10xulK7M6uUKb+y OmDL9rjJdlzrobGy2RAQPND1u/jt8l4joj0osg+uvA2JQ7F+cDXueIAjSJv+93cEnpBqUS kIwq3GJVc/g9hZrwUyvRQNvLcEUMWKI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1634542556; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g8AdCq04FqHxZQpu0wW2BfZ1BcVn5cU9ZAer2RqlbyU=; b=rfrbtomo9lq+oBn53trNDIVT6TJn1ZYkDmgs94WkvTb5FZPdBhzYkDi8HbtURx/iUzfoAl 3VzD429p2IwDnMAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EF3B213B44; Mon, 18 Oct 2021 07:35:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aEvpNtojbWFCEgAAMHmgww (envelope-from ); Mon, 18 Oct 2021 07:35:54 +0000 Date: Mon, 18 Oct 2021 09:35:53 +0200 From: Oscar Salvador To: Mike Kravetz Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Michal Hocko , Zi Yan , Muchun Song , Naoya Horiguchi , David Rientjes , "Aneesh Kumar K . V" , Nghia Le , Andrew Morton Subject: Re: [PATCH v4 1/5] hugetlb: add demote hugetlb page sysfs interfaces Message-ID: <20211018073552.GA11960@linux> References: <20211007181918.136982-1-mike.kravetz@oracle.com> <20211007181918.136982-2-mike.kravetz@oracle.com> <47e53389-638a-1af1-e94f-b3c7e5e7459e@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47e53389-638a-1af1-e94f-b3c7e5e7459e@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 524DB6001990 X-Stat-Signature: 16o7u7z5jjo5qkobkyxrwbftp5qx4myr Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="u2TIUP/M"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rfrbtomo; spf=pass (imf10.hostedemail.com: domain of osalvador@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de X-HE-Tag: 1634542554-323088 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 08, 2021 at 01:24:28PM -0700, Mike Kravetz wrote: > In general, the resize_lock prevents unexpected consequences when > multiple users are modifying the number of pages in a pool concurrently > from the proc/sysfs interfaces. The mutex is acquired here because we > are modifying (decreasing) the pool size. Yes, I got that. My question was wrt. n_mask initialization: + if (nid != NUMA_NO_NODE) { + init_nodemask_of_node(&nodes_allowed, nid); + n_mask = &nodes_allowed; + } else { + n_mask = &node_states[N_MEMORY]; + } AFAICS, this does not need to be protected. with that addressed: Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs