From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 287ABC433F5 for ; Thu, 21 Oct 2021 06:18:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AAC64611F2 for ; Thu, 21 Oct 2021 06:18:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AAC64611F2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id C2449900002; Thu, 21 Oct 2021 02:18:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BD3B16B0072; Thu, 21 Oct 2021 02:18:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE926900002; Thu, 21 Oct 2021 02:18:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id A08026B0071 for ; Thu, 21 Oct 2021 02:18:43 -0400 (EDT) Received: from smtpin33.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 424AF8249980 for ; Thu, 21 Oct 2021 06:18:43 +0000 (UTC) X-FDA: 78719440926.33.F8D9F23 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 388187001A24 for ; Thu, 21 Oct 2021 06:18:40 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 508AB68BEB; Thu, 21 Oct 2021 08:18:39 +0200 (CEST) Date: Thu, 21 Oct 2021 08:18:39 +0200 From: Christoph Hellwig To: Peter Zijlstra Cc: Lucas De Marchi , Christoph Hellwig , Andrew Morton , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Chris Wilson , linux-mm@kvack.org, matthew.auld@intel.com Subject: Re: [Intel-gfx] [PATCH 2/4] mm: add a io_mapping_map_user helper Message-ID: <20211021061839.GA27953@lst.de> References: <20210326055505.1424432-1-hch@lst.de> <20210326055505.1424432-3-hch@lst.de> <20211020154005.uk6u4ovcmlhpyubk@ldmartin-desk2> <20211020193751.GS174703@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211020193751.GS174703@worktop.programming.kicks-ass.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-Stat-Signature: j5d8ddw33hooysw4gkdm6f61akqhemzm X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 388187001A24 Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de X-HE-Tag: 1634797120-6875 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Oct 20, 2021 at 09:37:51PM +0200, Peter Zijlstra wrote: > > I'm not sure what exactly brought me to check this, but while debugging > > I noticed this outside the header guard. But then after some more checks I > > saw nothing actually selects CONFIG_IO_MAPPING because commit using > > it was reverted in commit 0e4fe0c9f2f9 ("Revert "i915: use io_mapping_map_user"") > > > > Is this something we want to re-attempt moving to mm/ ? > > Yes, it would be very good to unexport apply_to_page_range(), it's a > terrible interface to expose. Yes. We need to get back to this rather sooner than later. I'm a little swamped unfortunately.