From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4C8C433EF for ; Mon, 25 Oct 2021 13:30:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A684A60F9B for ; Mon, 25 Oct 2021 13:30:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A684A60F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 315736B006C; Mon, 25 Oct 2021 09:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C540940007; Mon, 25 Oct 2021 09:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DAE06B0073; Mon, 25 Oct 2021 09:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id 0DFB76B006C for ; Mon, 25 Oct 2021 09:30:08 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id A4C6018033E54 for ; Mon, 25 Oct 2021 13:30:07 +0000 (UTC) X-FDA: 78735043254.22.A58E029 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP id 0AF0A7001A05 for ; Mon, 25 Oct 2021 13:30:03 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id E982E60F46; Mon, 25 Oct 2021 13:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635168606; bh=Uy0l7Xr2fzwCMRbtUSSAU7UNyaQatmP0OTN2GIglWiM=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=u6kqskamokiskEaf1ytTiQ8jmpr5PktLgUYCcDi7GfCoHND8lgGhqcWqjBlw06/AF 7Tkh9juvollPdVkjHN11qnl9vmKwQJ9ZbeXc5f6qkwHPc9EO12YdNM7wawqCyJ30/V T1gAxyEqlXj8MnGpNmcwy1RuJd0KwyJ2WFNvCLNvoPo5VURw5RIw+As2WC2m1BYsL6 MvCVrHzcvOCTvFrpNKaXIpe0khgQnk28lJrV23TD2Q+/5qFMWE7DwmRglAL2fPnTJo wqypsERUyEz5gPVzXW//8QMEgl9ogo3+4NE9MYz8PnxFut6lnQlkyBtm/W4aTUWzXJ zb6IJUY2H6iag== From: SeongJae Park To: Yang Yingliang Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, sj@kernel.org Subject: Re: [PATCH -next] mm/damon: fix error return code in damon_reclaim_turn() Date: Mon, 25 Oct 2021 13:30:02 +0000 Message-Id: <20211025133002.27700-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211025124500.2758060-1-yangyingliang@huawei.com> X-Rspamd-Queue-Id: 0AF0A7001A05 Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=u6kqskam; spf=pass (imf02.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: j43fxzz9goi5ee6rq7r7b7hbw74w391w X-Rspamd-Server: rspam06 X-HE-Tag: 1635168603-199954 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Oct 2021 20:45:00 +0800 Yang Yingliang wrote: > If damon_reclaim_new_scheme() fails, it should return > error code in damon_reclaim_turn() > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Thank you for this fix! Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/reclaim.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > index f5ae4c422555..dc1485044eaf 100644 > --- a/mm/damon/reclaim.c > +++ b/mm/damon/reclaim.c > @@ -292,8 +292,10 @@ static int damon_reclaim_turn(bool on) > > /* Will be freed by 'damon_set_schemes()' below */ > scheme = damon_reclaim_new_scheme(); > - if (!scheme) > + if (!scheme) { > + err = -ENOMEM; > goto free_region_out; > + } > err = damon_set_schemes(ctx, &scheme, 1); > if (err) > goto free_scheme_out; > -- > 2.25.1 >