From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F53C433F5 for ; Mon, 25 Oct 2021 21:07:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AA1216105A for ; Mon, 25 Oct 2021 21:07:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA1216105A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 4925D940009; Mon, 25 Oct 2021 17:07:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 44096940007; Mon, 25 Oct 2021 17:07:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32F6B940009; Mon, 25 Oct 2021 17:07:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 225E1940007 for ; Mon, 25 Oct 2021 17:07:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id D46F82AEEB for ; Mon, 25 Oct 2021 21:07:43 +0000 (UTC) X-FDA: 78736196406.24.F0C9592 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf04.hostedemail.com (Postfix) with ESMTP id CE0E050000AD for ; Mon, 25 Oct 2021 21:07:38 +0000 (UTC) Received: by mail-pf1-f179.google.com with SMTP id k26so12147897pfi.5 for ; Mon, 25 Oct 2021 14:07:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TQztyN+OyqV2EYalpv3OnHEA+p7UGY3ffgQzpyFstrQ=; b=jPJwfXXczwHre/rQIPjK/VoVvO0IuwfH8WIMj2xxEOvALb2VPbYxNoqprq0OQR5nPC o5DyFtXCsBA94PwIkmXaD6fOOn6uzE1vuL8iTIZvpeFHN0NIs19av/f8DymXuOBARNDi 6wKlBs2WwIj2FcUduika3D+VnZO1ueK9qaM2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TQztyN+OyqV2EYalpv3OnHEA+p7UGY3ffgQzpyFstrQ=; b=bZ9iC799xyH695hBCtocz6ghc3gKPv7tCCIz7hpCyQwlc+REZwEJUYlAtSGftbyOiq sHl/b6Q7tbzK8qO43knqzI3A2/nPrbUec4SVAePb27H1fF7/At/LHBE2OAvdAjquaK7K G6dxBUOoZTz8edlkPXyq5FY7hftWtcLQqPpjwBHB8kAYWxO78eFl88CwRNTLLXRoQekd 61JJgyxhBMdNYGiofQ8l1TxCogCoydDefWpb7pSJbYRcOuOe8iulRZUQTsGI2T5TCUr+ LBg4iDZ+mZ1aLLjbwFPJgzbvt5KK+6nhtJCvU3blrbtqvJXiJyFa8R3SNwF6BtSqLCS2 fIDQ== X-Gm-Message-State: AOAM533TWJ5a4ICGmbDaueqp3VesYxW86+qLCbYIH65ldNlrVRhqAdqW r1KPmDnPZY+ONKgv6iQzX279wg== X-Google-Smtp-Source: ABdhPJz7CAVtw2oosUMB+o1UYU5LoroOh/r74Itpx8yjnMxuz2AoHAAIFbT9kzmQ6NZ1Nt3CdMAZTQ== X-Received: by 2002:a05:6a00:bc1:b0:47b:f093:eb4e with SMTP id x1-20020a056a000bc100b0047bf093eb4emr8462611pfu.55.1635196062554; Mon, 25 Oct 2021 14:07:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id oj5sm8917184pjb.45.2021.10.25.14.07.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Oct 2021 14:07:42 -0700 (PDT) Date: Mon, 25 Oct 2021 14:07:33 -0700 From: Kees Cook To: Yafang Shao Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, arnaldo.melo@gmail.com, pmladek@suse.com, peterz@infradead.org, viro@zeniv.linux.org.uk, valentin.schneider@arm.com, qiang.zhang@windriver.com, robdclark@chromium.org, christian@brauner.io, dietmar.eggemann@arm.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, davem@davemloft.net, kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, oliver.sang@intel.com, lkp@intel.com, Andrii Nakryiko Subject: Re: [PATCH v6 01/12] fs/exec: make __set_task_comm always set a nul ternimated string Message-ID: <202110251407.6FD1411ECB@keescook> References: <20211025083315.4752-1-laoar.shao@gmail.com> <20211025083315.4752-2-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211025083315.4752-2-laoar.shao@gmail.com> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: CE0E050000AD X-Stat-Signature: i9ubrqkxex57igankkw1977aamdxdaew Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=jPJwfXXc; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.179 as permitted sender) smtp.mailfrom=keescook@chromium.org X-HE-Tag: 1635196058-427085 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 25, 2021 at 08:33:04AM +0000, Yafang Shao wrote: > Make sure the string set to task comm is always nul ternimated. typo nit: "terminated" > > Signed-off-by: Yafang Shao Reviewed-by: Kees Cook -- Kees Cook