From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D00C433F5 for ; Tue, 26 Oct 2021 07:06:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 73ECA6109D for ; Tue, 26 Oct 2021 07:06:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73ECA6109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 10AE980007; Tue, 26 Oct 2021 03:06:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BA5C940007; Tue, 26 Oct 2021 03:06:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F120380007; Tue, 26 Oct 2021 03:06:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id E4344940007 for ; Tue, 26 Oct 2021 03:06:46 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A27D223E5D for ; Tue, 26 Oct 2021 07:06:46 +0000 (UTC) X-FDA: 78737706012.28.5C72430 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf14.hostedemail.com (Postfix) with ESMTP id 36EBC600198E for ; Tue, 26 Oct 2021 07:06:47 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id ED5D160E8B; Tue, 26 Oct 2021 07:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635232005; bh=RQiaWvZxi6P05j9XkrMk/0RKqbNxLYI79zOYLUTn8dc=; h=From:To:Cc:Subject:Date:In-Reply-To:From; b=T61Hnp6RsutyC52LEy2tcuJcWKRFZ7uzOS/gQLF6Ss0C15fxCyZXz9zZUied95caD BTlhah+hmp5lbIZiqty8gh/KWf2tNdl73D0UdXk2sCsaktK4YNbc6AL8hvcP5oCcJx 3/MH1lAXmdaCAL2GpeNFQrXWeKnDnlOx6vy6ni2MgynFwMIMWdVCUHYzWk1tXP3qwK 8uPidAZ1xdjSrJoHLM3g3+34EOZTp4oEqpP+iXuSIKEyD65MowLnv9y43ei32v64ar z/f/6GA3LZTCtZ4lY5V1CaQ7590/8WOVn0wi70nmVAB7sYpat1dGjLWEDz0XzpbfO/ i0+M5zvOa5NvA== From: SeongJae Park To: SeongJae Park Cc: Yang Yingliang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org Subject: Re: [PATCH -next] mm/damon: fix error return code in damon_reclaim_turn() Date: Tue, 26 Oct 2021 07:06:37 +0000 Message-Id: <20211026070637.30044-1-sj@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20211025133002.27700-1-sj@kernel.org> X-Rspamd-Queue-Id: 36EBC600198E Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T61Hnp6R; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-Stat-Signature: 94bd5owhaudgmnxiac84wrhnzk1uuxsk X-Rspamd-Server: rspam06 X-HE-Tag: 1635232007-811184 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 25 Oct 2021 13:30:02 +0000 SeongJae Park wrote: > On Mon, 25 Oct 2021 20:45:00 +0800 Yang Yingliang wrote: > > > If damon_reclaim_new_scheme() fails, it should return > > error code in damon_reclaim_turn() > > > > Reported-by: Hulk Robot > > Signed-off-by: Yang Yingliang > > Thank you for this fix! > > Reviewed-by: SeongJae Park FWIW, this patch fixes commit 53ab0082dc41 ("mm/damon: introduce DAMON-based Reclamation (DAMON_RECLAIM)") in -mm[1]. [1] https://github.com/hnaz/linux-mm/commit/53ab0082dc41 Thanks, SJ > > > Thanks, > SJ > > > --- > > mm/damon/reclaim.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/mm/damon/reclaim.c b/mm/damon/reclaim.c > > index f5ae4c422555..dc1485044eaf 100644 > > --- a/mm/damon/reclaim.c > > +++ b/mm/damon/reclaim.c > > @@ -292,8 +292,10 @@ static int damon_reclaim_turn(bool on) > > > > /* Will be freed by 'damon_set_schemes()' below */ > > scheme = damon_reclaim_new_scheme(); > > - if (!scheme) > > + if (!scheme) { > > + err = -ENOMEM; > > goto free_region_out; > > + } > > err = damon_set_schemes(ctx, &scheme, 1); > > if (err) > > goto free_scheme_out; > > -- > > 2.25.1 > >