From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=rmuZ=QE=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 92E21C433F5
	for <linux-mm@archiver.kernel.org>; Wed, 17 Nov 2021 09:38:04 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 110036321A
	for <linux-mm@archiver.kernel.org>; Wed, 17 Nov 2021 09:38:04 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 110036321A
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org
Received: by kanga.kvack.org (Postfix)
	id 2EB216B0073; Wed, 17 Nov 2021 04:37:46 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id 29A6A6B0074; Wed, 17 Nov 2021 04:37:46 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id 189D76B0078; Wed, 17 Nov 2021 04:37:46 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0186.hostedemail.com [216.40.44.186])
	by kanga.kvack.org (Postfix) with ESMTP id 0ACA86B0073
	for <linux-mm@kvack.org>; Wed, 17 Nov 2021 04:37:46 -0500 (EST)
Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay05.hostedemail.com (Postfix) with ESMTP id C929E1838E516
	for <linux-mm@kvack.org>; Wed, 17 Nov 2021 09:37:35 +0000 (UTC)
X-FDA: 78817919670.15.64ABC69
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf28.hostedemail.com (Postfix) with ESMTP id 579B790000B9
	for <linux-mm@kvack.org>; Wed, 17 Nov 2021 09:37:35 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id 68C3268B05; Wed, 17 Nov 2021 10:37:33 +0100 (CET)
Date: Wed, 17 Nov 2021 10:37:33 +0100
From: Christoph Hellwig <hch@lst.de>
To: Joao Martins <joao.m.martins@oracle.com>
Cc: linux-mm@kvack.org, Dan Williams <dan.j.williams@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>,
	Dave Jiang <dave.jiang@intel.com>,
	Naoya Horiguchi <naoya.horiguchi@nec.com>,
	Matthew Wilcox <willy@infradead.org>,
	Jason Gunthorpe <jgg@ziepe.ca>, John Hubbard <jhubbard@nvidia.com>,
	Jane Chu <jane.chu@oracle.com>,
	Muchun Song <songmuchun@bytedance.com>,
	Mike Kravetz <mike.kravetz@oracle.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jonathan Corbet <corbet@lwn.net>, Christoph Hellwig <hch@lst.de>,
	nvdimm@lists.linux.dev, linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 7/8] device-dax: ensure dev_dax->pgmap is valid for
 dynamic devices
Message-ID: <20211117093733.GB8429@lst.de>
References: <20211112150824.11028-1-joao.m.martins@oracle.com> <20211112150824.11028-8-joao.m.martins@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211112150824.11028-8-joao.m.martins@oracle.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Rspamd-Server: rspam01
X-Rspamd-Queue-Id: 579B790000B9
X-Stat-Signature: grcf3qjgfadmiko6ee6umneyuy5ai5so
Authentication-Results: imf28.hostedemail.com;
	dkim=none;
	dmarc=none;
	spf=none (imf28.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de
X-HE-Tag: 1637141855-333635
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

> +bool static_dev_dax(struct dev_dax *dev_dax)
> +{
> +	return is_static(dev_dax->region);
> +}
> +EXPORT_SYMBOL_GPL(static_dev_dax);

This function would massively benefit from documentic what a static
DAX region is and why someone would want to care.  Because even as
someone occasionally dabbling with the DAX code I have no idea at all
what that means.