From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB6F7C433F5 for ; Sat, 4 Dec 2021 09:54:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F7206B0082; Sat, 4 Dec 2021 04:53:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A6006B0083; Sat, 4 Dec 2021 04:53:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56EDC6B0085; Sat, 4 Dec 2021 04:53:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id 48A516B0082 for ; Sat, 4 Dec 2021 04:53:22 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 00A5D89943 for ; Sat, 4 Dec 2021 09:53:12 +0000 (UTC) X-FDA: 78879648624.12.858921D Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf28.hostedemail.com (Postfix) with ESMTP id A2E39900009A for ; Sat, 4 Dec 2021 09:53:11 +0000 (UTC) Received: by mail-pl1-f171.google.com with SMTP id b11so3751112pld.12 for ; Sat, 04 Dec 2021 01:53:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KNky9vHErqn9OL9wm+gliP7fCGte3KeREk90aKC+mg=; b=qsHK5Wp3DDnxrHGKr78oHp3IvG22FXMQ6WLWibND/E4BbWM4VRjvkAOOeDurq/WY2z fOAeQgN/6YWcrKHrMoT2GS3f/Mc7fS1YBcI7oD9q/GKw3m0e4Gr7c3s5n9lB2VkrNMed UtdMn06egm/MpTXviwqTxAIO6ehe3o5MT9YHEmmQK93GlVRGSN/qnBnuwpCcK3S2inJR sNVFHTPd4HdI4Szm8nxVoxpw6iVU0r3IcOYsT4R/5ZyjNtEvX64EtfZ9S8u1M/a9WdG0 7yz9zKW0X0SDPHB1FlCbkCy7K4rbSCIL3m6c7UPYgDAJtWjwtq1TMgbS7AcjwwbYPHSl mbpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KNky9vHErqn9OL9wm+gliP7fCGte3KeREk90aKC+mg=; b=fmywEOIbJcXVBya719/G+umXHC519ScFLU1MYp58U3zHIkJ0u3EyaxNHB608jRmsI1 b0hGPQFFbFkRbH5Xo0ninpZbuiL2Gl6FgiYBgtWs9At14Cr1LrmPCLeBBNv9JphfGjsz goZ3c0FUvpkEnM8yAXBVAIxXeuFaRB0eikfDZh6dfbppnt/yDTsSCAAghZcbVkzJwpTZ ojWSuYm2ZyfRAMb9fKQvQBk+l57PIX7jEzy5NPCwVCdTjiFupVp+QlM6dn62TP/QYLJ+ DauleMwr8TDmrRJXskEUb6mJ108v41pvi4fNrH4j+y5dwevRL3eiruCGmUC4iHEgfxki RJeQ== X-Gm-Message-State: AOAM533vR56uag8lKvkWu1dRDtTGNSqjWJxxI+QQctBuZRl+BTMBih9h J92559AkabvylLhRXPj3bsY= X-Google-Smtp-Source: ABdhPJwqg6pKyGYMoMdlo2j7xJDfBIjTYhK1gMRW2j6TUtLmctuFv3TisafzMoi0MWS2K97dkPcYqQ== X-Received: by 2002:a17:902:bcc4:b0:141:bfc4:ada with SMTP id o4-20020a170902bcc400b00141bfc40adamr28918047pls.20.1638611590852; Sat, 04 Dec 2021 01:53:10 -0800 (PST) Received: from vultr.guest ([45.76.74.237]) by smtp.gmail.com with ESMTPSA id ms15sm4343198pjb.26.2021.12.04.01.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Dec 2021 01:53:10 -0800 (PST) From: Yafang Shao To: akpm@linux-foundation.org, rostedt@goodmis.org, keescook@chromium.org, pmladek@suse.com, david@redhat.com, arnaldo.melo@gmail.com, andrii.nakryiko@gmail.com Cc: linux-mm@kvack.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Yafang Shao , Mathieu Desnoyers , Alexei Starovoitov , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro Subject: [PATCH -mm 3/5] samples/bpf/tracex2: replace hard-coded 16 with TASK_COMM_LEN Date: Sat, 4 Dec 2021 09:52:54 +0000 Message-Id: <20211204095256.78042-4-laoar.shao@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20211204095256.78042-1-laoar.shao@gmail.com> References: <20211204095256.78042-1-laoar.shao@gmail.com> MIME-Version: 1.0 X-Stat-Signature: q141d5m1spm5pkwawfztak1zx4g5ejk6 Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qsHK5Wp3; spf=pass (imf28.hostedemail.com: domain of laoar.shao@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=laoar.shao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: A2E39900009A X-HE-Tag: 1638611591-880738 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comm used in tracex2 should have the same size with the comm in task_struct, we'd better define the size of it as TASK_COMM_LEN to make i= t more grepable. linux/sched.h can be included in tracex2 kernel code, but it can't be included in tracex2 userspace code. So a new marco TASK_COMM_LEN is defined in tracex2 userspace code. Signed-off-by: Yafang Shao Cc: Mathieu Desnoyers Cc: Arnaldo Carvalho de Melo Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Michal Miroslaw Cc: Peter Zijlstra Cc: Steven Rostedt Cc: Matthew Wilcox Cc: David Hildenbrand Cc: Al Viro Cc: Kees Cook Cc: Petr Mladek --- samples/bpf/tracex2_kern.c | 3 ++- samples/bpf/tracex2_user.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/samples/bpf/tracex2_kern.c b/samples/bpf/tracex2_kern.c index 5bc696bac27d..51dbaf765cd5 100644 --- a/samples/bpf/tracex2_kern.c +++ b/samples/bpf/tracex2_kern.c @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -65,7 +66,7 @@ static unsigned int log2l(unsigned long v) } =20 struct hist_key { - char comm[16]; + char comm[TASK_COMM_LEN]; u64 pid_tgid; u64 uid_gid; u64 index; diff --git a/samples/bpf/tracex2_user.c b/samples/bpf/tracex2_user.c index 1626d51dfffd..b728a946d83d 100644 --- a/samples/bpf/tracex2_user.c +++ b/samples/bpf/tracex2_user.c @@ -12,6 +12,7 @@ =20 #define MAX_INDEX 64 #define MAX_STARS 38 +#define TASK_COMM_LEN 16 =20 /* my_map, my_hist_map */ static int map_fd[2]; @@ -28,7 +29,7 @@ static void stars(char *str, long val, long max, int wi= dth) } =20 struct task { - char comm[16]; + char comm[TASK_COMM_LEN]; __u64 pid_tgid; __u64 uid_gid; }; --=20 2.17.1